New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Microsoft.DotNet.BuildTools.Coreclr from source in the open #14345

Open
weshaggard opened this Issue Oct 5, 2017 · 5 comments

Comments

Projects
None yet
6 participants
@weshaggard
Member

weshaggard commented Oct 5, 2017

The Microsoft.DotNet.BuildTools.Coreclr is needed to build CoreCLR repo, at least on the windows builds
https://github.com/dotnet/coreclr/blob/master/init-tools.msbuild#L12. In order to enable our build form source efforts we need to build this package from the open.

@jkotas do you know who owns this package?

@jkotas

This comment has been minimized.

Show comment
Hide comment
@jkotas

jkotas Oct 5, 2017

Member

This package contains DacTableGen, GenClrDebugResource, InjectResource tools. These tools are required by the debugger support. I think that these tools should be owned by @lt72 team these days.

Note that we have all sources out there. We just do not have the package authoring.

Member

jkotas commented Oct 5, 2017

This package contains DacTableGen, GenClrDebugResource, InjectResource tools. These tools are required by the debugger support. I think that these tools should be owned by @lt72 team these days.

Note that we have all sources out there. We just do not have the package authoring.

@lt72

This comment has been minimized.

Show comment
Hide comment
@lt72

lt72 Oct 5, 2017

Contributor

@chsienki can own this. What is the timeline here?

Contributor

lt72 commented Oct 5, 2017

@chsienki can own this. What is the timeline here?

@weshaggard

This comment has been minimized.

Show comment
Hide comment
@weshaggard

weshaggard Oct 5, 2017

Member

We are targeting 2.1 time frame for this effort.

Member

weshaggard commented Oct 5, 2017

We are targeting 2.1 time frame for this effort.

@lt72 lt72 added this to the 2.1.0 milestone Oct 5, 2017

@lt72 lt72 added the enhancement label Oct 31, 2017

@noahfalk noahfalk modified the milestones: 2.1.0, Future Mar 28, 2018

@eerhardt

This comment has been minimized.

Show comment
Hide comment
@eerhardt

eerhardt May 30, 2018

Member

Looks like 2.1 was not the time frame for this effort.

Anyone have an update on where we are with this?

I think it would be great if we could consolidate the tools into the dotnet/arcade repo along with the rest of the tools we need to build the product. /cc @markwilkie

Member

eerhardt commented May 30, 2018

Looks like 2.1 was not the time frame for this effort.

Anyone have an update on where we are with this?

I think it would be great if we could consolidate the tools into the dotnet/arcade repo along with the rest of the tools we need to build the product. /cc @markwilkie

@chsienki

This comment has been minimized.

Show comment
Hide comment
@chsienki

chsienki Jun 1, 2018

Contributor

It looks like @vancem started making some of this work, as DacTableGen is now built from source first and used, rather than using the package version (for 2017 at least) ebdc98c. I don't see why we couldn't do the same for the other tools, and totally drop the usage of the buildtools package.

I don't think they're used anywhere other than this repo, so I'm not sure its worth migrating them to arcade at this point.

Contributor

chsienki commented Jun 1, 2018

It looks like @vancem started making some of this work, as DacTableGen is now built from source first and used, rather than using the package version (for 2017 at least) ebdc98c. I don't see why we couldn't do the same for the other tools, and totally drop the usage of the buildtools package.

I don't think they're used anywhere other than this repo, so I'm not sure its worth migrating them to arcade at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment