New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiered Jitting: Fix IL to native mapping for ETW #14947

Closed
noahfalk opened this Issue Nov 9, 2017 · 1 comment

Comments

Projects
None yet
4 participants
@noahfalk
Copy link
Member

noahfalk commented Nov 9, 2017

ETW emits a Native->IL mapping data for each jitted version and doing code review I can see that it probably isn't emitting the correct mapping.

https://github.com/dotnet/coreclr/blob/master/src/vm/eventtrace.cpp#L6667

The signature of this method uses a MethodDesc and a ReJITID, neither of which is a strong enough identifier to isolate which version of tiered jitting code is being refered to. Without knowing which jitted instance to emit the IL->Native map for and knowing that the maps differ, at least some of the versions must be wrong.

@davmason

This comment has been minimized.

Copy link
Member

davmason commented Nov 18, 2017

Fixed with #15038

@davmason davmason closed this Nov 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment