New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[x64/windows] System.Runtime.InteropServices.Tests failed in x64_checked_windows_nt_corefx_baseline #21398

Closed
AriNuer opened this Issue Dec 6, 2018 · 8 comments

Comments

Projects
None yet
4 participants
@AriNuer
Member

AriNuer commented Dec 6, 2018

Job:
https://ci.dot.net/job/dotnet_coreclr/job/master/view/x64/job/jitstress/job/x64_checked_windows_nt_corefx_baseline/709/#showFailuresLink
Failed tests:
System.Runtime.InteropServices.Tests.GetComInterfaceForObjectTests.GetComInterfaceForObject_ObjectNotCollectible_ThrowsNotSupportedException
System.Runtime.InteropServices.Tests.ChangeWrapperHandleStrengthTests.ChangeWrapperHandleStrength_ObjectNotCollectible_ThrowsNotSupportedException
System.Runtime.InteropServices.Tests.CreateAggregatedObjectTests.CreateAggregatedObject_ObjectNotCollectible_ReturnsExpected
System.Runtime.InteropServices.Tests.GetNativeVariantForObjectTests.GetNativeVariantForObject_ObjectNotCollectible_ThrowsNotSupportedException
System.Runtime.InteropServices.Tests.GetIUnknownForObjectTests.GetIUnknownForObject_ObjectNotCollectible_ThrowsNotSupportedException
Failed log:

Discovering: System.Runtime.InteropServices.Tests (method display = ClassAndMethod, method display options = None)
    Discovered:  System.Runtime.InteropServices.Tests (found 563 of 616 test cases)
    Starting:    System.Runtime.InteropServices.Tests (parallel test collections = on, max threads = 4)
      System.Runtime.InteropServices.Tests.ChangeWrapperHandleStrengthTests.ChangeWrapperHandleStrength_ObjectNotCollectible_ThrowsNotSupportedException [FAIL]
        Assert.Throws() Failure
        Expected: typeof(System.NotSupportedException)
        Actual:   (No exception was thrown)
        Stack Trace:
          D:\j\workspace\x64_checked_w---a7bd363e\_\fx\src\System.Runtime.InteropServices\tests\System\Runtime\InteropServices\Marshal\ChangeWrapperHandleStrengthTests.cs(66,0): at System.Runtime.InteropServices.Tests.ChangeWrapperHandleStrengthTests.ChangeWrapperHandleStrength_ObjectNotCollectible_ThrowsNotSupportedException()
      System.Runtime.InteropServices.Tests.GetComInterfaceForObjectTests.GetComInterfaceForObject_ObjectNotCollectible_ThrowsNotSupportedException [FAIL]
        Assert.Throws() Failure
        Expected: typeof(System.NotSupportedException)
        Actual:   typeof(System.InvalidCastException): Specified cast is not valid.
        ---- System.InvalidCastException : Specified cast is not valid.
        Stack Trace:
             at System.Runtime.InteropServices.Marshal.GetComInterfaceForObjectNative(Object o, Type t, Boolean onlyInContext, Boolean fEnalbeCustomizedQueryInterface)
          D:\j\workspace\x64_checked_w---a7bd363e\_\fx\src\System.Runtime.InteropServices\tests\System\Runtime\InteropServices\Marshal\GetComInterfaceForObjectTests.cs(220,0): at System.Runtime.InteropServices.Tests.GetComInterfaceForObjectTests.<>c__DisplayClass15_0.<GetComInterfaceForObject_ObjectNotCollectible_ThrowsNotSupportedException>b__0()
          ----- Inner Stack Trace -----
             at System.Runtime.InteropServices.Marshal.GetComInterfaceForObjectNative(Object o, Type t, Boolean onlyInContext, Boolean fEnalbeCustomizedQueryInterface)
          D:\j\workspace\x64_checked_w---a7bd363e\_\fx\src\System.Runtime.InteropServices\tests\System\Runtime\InteropServices\Marshal\GetComInterfaceForObjectTests.cs(220,0): at System.Runtime.InteropServices.Tests.GetComInterfaceForObjectTests.<>c__DisplayClass15_0.<GetComInterfaceForObject_ObjectNotCollectible_ThrowsNotSupportedException>b__0()
      System.Runtime.InteropServices.Tests.CreateAggregatedObjectTests.CreateAggregatedObject_ObjectNotCollectible_ReturnsExpected [FAIL]
        Assert.Throws() Failure
        Expected: typeof(System.NotSupportedException)
        Actual:   (No exception was thrown)
        Stack Trace:
          D:\j\workspace\x64_checked_w---a7bd363e\_\fx\src\System.Runtime.InteropServices\tests\System\Runtime\InteropServices\Marshal\CreateAggregatedObjectTests.cs(134,0): at System.Runtime.InteropServices.Tests.CreateAggregatedObjectTests.CreateAggregatedObject_ObjectNotCollectible_ReturnsExpected()
      System.Runtime.InteropServices.Tests.GetNativeVariantForObjectTests.GetNativeVariantForObject_ObjectNotCollectible_ThrowsNotSupportedException [FAIL]
        Assert.Throws() Failure
        Expected: typeof(System.NotSupportedException)
        Actual:   (No exception was thrown)
        Stack Trace:
             at System.Runtime.InteropServices.Tests.GetNativeVariantForObjectTests.GetNativeVariantForObject_ObjectNotCollectible_ThrowsNotSupportedException()
      System.Runtime.InteropServices.Tests.GetIUnknownForObjectTests.GetIUnknownForObject_ObjectNotCollectible_ThrowsNotSupportedException [FAIL]
        Assert.Throws() Failure
        Expected: typeof(System.NotSupportedException)
        Actual:   (No exception was thrown)
        Stack Trace:
          D:\j\workspace\x64_checked_w---a7bd363e\_\fx\src\System.Runtime.InteropServices\tests\System\Runtime\InteropServices\Marshal\GetIUnknownForObjectTests.cs(39,0): at System.Runtime.InteropServices.Tests.GetIUnknownForObjectTests.GetIUnknownForObject_ObjectNotCollectible_ThrowsNotSupportedException()
    Finished:    System.Runtime.InteropServices.Tests
@AaronRobinsonMSFT

This comment has been minimized.

Member

AaronRobinsonMSFT commented Dec 6, 2018

@janvorli Looks like this is related to your collectable classes work. Anything I can do to help here?

@BruceForstall

This comment has been minimized.

Contributor

BruceForstall commented Dec 7, 2018

These also fail on x86

@BruceForstall

This comment has been minimized.

Contributor

BruceForstall commented Dec 7, 2018

Looks like #20919 probably introduced the failures.

@janvorli

This comment has been minimized.

Member

janvorli commented Dec 7, 2018

These tests are not valid anymore (they were testing that attempt to use COM interop for collectible classes would fail). They just need to be disabled using the tests\CoreFX\CoreFX.issues.json file. I'll send out a PR soon.

@BruceForstall

This comment has been minimized.

Contributor

BruceForstall commented Dec 7, 2018

@janvorli Can you disable them in CoreFX? The problem is that we run 2 types of corefx testing in coreclr: the "innerloop" (new) style, disabled by the file you reference, and the "old" style, with various files for disabling in tests\arm and tests\arm64, but no way to disable for x86/x64

@janvorli

This comment has been minimized.

Member

janvorli commented Dec 7, 2018

They were already deleted in corefx. The issue is that the corefx tests version we use in coreclr is old and still contains tests that were deleted from the corefx repo. That's why we have the tests\CoreFX\CoreFX.issues.json file so that we can disable them without updating the version. At least that's my understanding.

@BruceForstall

This comment has been minimized.

Contributor

BruceForstall commented Dec 7, 2018

When were they deleted? Our non-innerloop corefx tests (corefx_baseline and other corefx_* tests) always clone corefx master branch and build/run it. You're right about the corefx "innerloop" job using cached tests.

@janvorli

This comment has been minimized.

Member

janvorli commented Dec 7, 2018

They were deleted yesterday: dotnet/corefx#33842

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment