Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide the appropriate intrinsic implementations for specific single-precision math functions #7689

Closed
tannergooding opened this Issue Oct 18, 2016 · 2 comments

Comments

Projects
None yet
1 participant
@tannergooding
Copy link
Member

tannergooding commented Oct 18, 2016

PR #5492 implemented dotnet/corefx#1151, by providing scalar single-precision floating-point support for many of the trigonometric, logarithmic, and other common mathematical functions.

However, there is still the additional work that needs to be done where the new intrinsics are properly plumbed through the ValueNumStore.

PR #5492 has some details on what needs to be done here, but essentially:

Pretty much all of the intrinsic hookup work, as I understand it, is in the valueenum.cpp file. However, there does not appear to be much (if any) documentation on the ValueNumStore.

@tannergooding tannergooding self-assigned this Oct 18, 2016

@tannergooding

This comment has been minimized.

Copy link
Member Author

tannergooding commented Oct 18, 2016

I am self-assigning these for the time being and am going to work on getting these completed.

@tannergooding

This comment has been minimized.

Copy link
Member Author

tannergooding commented Feb 24, 2017

This was resolved with #9363 and #9717

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.