New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Span: Add tests to verify type loader checks for ref-like types #8516

Closed
jkotas opened this Issue Dec 8, 2016 · 6 comments

Comments

Projects
None yet
6 participants
@jkotas
Member

jkotas commented Dec 8, 2016

  • Span cannot be boxed
  • Span cannot be used as argument of generic instantiations
  • Span cannot be used as type of static fields or non-value type instance fields

@jkotas jkotas referenced this issue Dec 8, 2016

Closed

Span<T> #5851

25 of 28 tasks complete

@joshfree joshfree changed the title from Add tests to verify type loader checks for ref-like types to Span: Add tests to verify type loader checks for ref-like types Dec 15, 2016

@gkhanna79 gkhanna79 added this to the 2.0.0 milestone Dec 21, 2016

@gkhanna79 gkhanna79 assigned kouvel and unassigned gkhanna79 Jan 4, 2017

kouvel added a commit to kouvel/coreclr that referenced this issue Jan 23, 2017

Disallow statics of spans and class instance members of span
Functional fix for #8516 to cover some additional cases. IL tests will be coming later in a separate PR.

jkotas added a commit that referenced this issue Jan 24, 2017

Disallow statics of spans and class instance members of span (#9061)
Functional fix for #8516 to cover some additional cases. IL tests will be coming later in a separate PR.
@ahsonkhan

This comment has been minimized.

Show comment
Hide comment
@ahsonkhan

ahsonkhan Apr 4, 2017

Member

@kouvel, any updates on this issue?

Member

ahsonkhan commented Apr 4, 2017

@kouvel, any updates on this issue?

@kouvel

This comment has been minimized.

Show comment
Hide comment
@kouvel

kouvel Apr 5, 2017

Member

I had tested the C# versions of these tests and all is good, just need to convert them to IL tests

Member

kouvel commented Apr 5, 2017

I had tested the C# versions of these tests and all is good, just need to convert them to IL tests

@kouvel kouvel modified the milestones: Future, 2.0.0 Apr 5, 2017

@jkotas jkotas modified the milestones: Future, 2.1.0 Sep 22, 2017

@ahsonkhan

This comment has been minimized.

Show comment
Hide comment
@ahsonkhan

ahsonkhan Oct 18, 2017

Member

@kouvel, any updates on this issue?
This is one of the two remaining issues under "VM - Correctness" from #5851 (comment)

Member

ahsonkhan commented Oct 18, 2017

@kouvel, any updates on this issue?
This is one of the two remaining issues under "VM - Correctness" from #5851 (comment)

@kouvel

This comment has been minimized.

Show comment
Hide comment
@kouvel

kouvel Oct 18, 2017

Member

Nope, haven't had the time to look at my issues

Member

kouvel commented Oct 18, 2017

Nope, haven't had the time to look at my issues

@ahsonkhan

This comment has been minimized.

Show comment
Hide comment
@ahsonkhan

ahsonkhan Dec 15, 2017

Member

@kouvel, can you please triage/prioritize this issue. Ty

Member

ahsonkhan commented Dec 15, 2017

@kouvel, can you please triage/prioritize this issue. Ty

@ahsonkhan

This comment has been minimized.

Show comment
Hide comment
@ahsonkhan

ahsonkhan Jan 6, 2018

Member

Fixed in #15745.
Closing.

Member

ahsonkhan commented Jan 6, 2018

Fixed in #15745.
Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment