MacOSX Support #105
MacOSX Support #105
Conversation
|
Seems the CI linux fails on your builder. Any chance of getting a VERBOSE=1 build to figure out why? |
|
Windows build is fixed. Your linux build can't seem to find ar based on one of my changes. I'm on 64-bit trusty. Can you please let me know what you're buildbot is verifying against? |
|
Is enabling the build on 32 bit linux possible? |
|
@kangaroo This is awesome! Thank you so much for doing it! I’ll start reviewing it in the morning. Regarding conig.h: the plan is to be able to generate it automatically. The one that we currently have in the source tree is a temporary thing that I created in almost automated way with some manual adjustments. :) I do have configure.in but it needs a number of fixes before I can check it in. Once again, thank you for your contribution! |
|
@kangaroo ... and, by the way, about our lab verification. We are using Ubuntu 14.04 with llvm 3.5 and cmake 2.8.12 installed. Currently this is the only configuration that we are testing and supporting. Thank you. |
| endif(CMAKE_SYSTEM_PROCESSOR STREQUAL x86_64) | ||
| endif(CLR_CMAKE_PLATFORM_LINUX) | ||
| if(CLR_CMAKE_PLATFORM_DARWIN) | ||
| add_definitions(-D_XOPEN_SOURCE) |
There was a problem hiding this comment.
i think here also should be a message like detected darwin.
|
Could you please submit the change in the 1000+ autogenerated test CMakeFiles as separate PR, so that the rest is easier to deal with. |
|
@sergiy-k Hrmm.. my linux VM is the same, so I'm not sure why the link is failing to find ar. |
|
Linux build issue was a typo in the gen-buildsys-clang.sh. Running a test build now, and should be committing it shortly. |
| OS=`uname` | ||
|
|
||
| if [ $OS = "Linux" ]; then | ||
| NPROCS=`grep -c ^processor /proc/cpuinfo` |
There was a problem hiding this comment.
I think this has been already address in a slightly different way in #100
There was a problem hiding this comment.
I'll merge it back once thats merged to master.
There was a problem hiding this comment.
#100 was merged to master. Could you please also squash the commits?
|
Grrr.. my rebase discarded my changes somehow. Going to need to redo that. |
|
@kangaroo You mean you lost everything? I'm so sorry to hear that... :( |
|
@kangaroo You scared me. Now I'm again in good mood. :) |
|
@sergiy-k Always make a backup before messing around with rebasing and force pushing :) |
|
Great! It works! |
|
@cnblogs-dudu I can upload a corlib you can use when I get back from dinner of you like. Building it is a little onerous right now |
|
Sample corlib available at: |
|
@kangaroo |
Alright, total brain dump pull request. I had some time and made mac work. Simple CLR programs run, more complicated stuff does not yet.
A few notable things:
I'm not sure how much time I'll have to do serious refactoring if required, but lets discuss. It might be preferable to squash this? In the worst case this is a kick off point for others who want to do bring-up.