Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch multicast delegate stub on Windows x64 to use stubs-as-il #11624

Merged
merged 1 commit into from May 17, 2017

Conversation

@jkotas
Copy link
Member

commented May 15, 2017

Fixes #11611. The old hand generated assembly path did not work well for structs passed by reference.

Fixes #11611. The old hand generated assembly path did not work well for structs passed by reference.
@jkotas jkotas force-pushed the jkotas:issue-11611 branch from 1bf9829 to 96f1571 May 15, 2017
@jkotas jkotas requested a review from janvorli May 16, 2017
Copy link
Member

left a comment

LGTM, thank you!

@janvorli janvorli merged commit b6f9dbf into dotnet:master May 17, 2017
19 checks passed
19 checks passed
CROSS Check Build finished.
Details
CentOS7.1 x64 Debug Build and Test Build finished.
Details
FreeBSD x64 Checked Build Build finished.
Details
OSX10.12 x64 Checked Build and Test Build finished.
Details
Tizen armel Cross Debug Build Build finished.
Details
Tizen armel Cross Release Build Build finished.
Details
Ubuntu arm Cross Release Build Build finished.
Details
Ubuntu x64 Checked Build and Test Build finished.
Details
Ubuntu x64 Formatting Build finished.
Details
Ubuntu16.04 arm Cross Debug Build Build finished.
Details
Windows_NT arm Cross Debug Build Build finished.
Details
Windows_NT arm Cross Release Build Build finished.
Details
Windows_NT arm64 Cross Debug Build Build finished.
Details
Windows_NT x64 CoreCLR Perf Tests Correctness Build finished.
Details
Windows_NT x64 Debug Build and Test Build finished.
Details
Windows_NT x64 Formatting Build finished.
Details
Windows_NT x64 Release Priority 1 Build and Test Build finished.
Details
Windows_NT x86 Checked Build and Test Build finished.
Details
Windows_NT x86 CoreCLR Perf Tests Correctness Build finished.
Details
@jkotas jkotas deleted the jkotas:issue-11611 branch May 17, 2017
@karelz karelz added this to the 2.1.0 milestone Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.