This repository was archived by the owner on Jan 23, 2023. It is now read-only.
More update in /dev/defaultintf #11693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 7, 2017 15:43
Author
|
@dotnet-bot Test this please |
Author
|
@davidwrighton Sorry I forgot to ask for a review. Can you take a look and comment on it? I'll address them in my next PR. |
yizhang82
added a commit
that referenced
this pull request
May 23, 2017
* Support non-virtual calls on interface private members correctly * Support protected methods * Properly handle precode * Throw (tentative) exception when seeing conflict overrides and add a test case (This updates CoreCLR dev/defaultintf the same with the build we are showing at //build)
| else | ||
| // Force all interface calls to be interpreted as if they are virtual. | ||
| if (pTargetMD->GetMethodTable()->IsInterface()) | ||
| if (pTargetMD->GetMethodTable()->IsInterface() && pTargetMD->IsVirtual()) |
Member
There was a problem hiding this comment.
This may block the ability to have base.Method() calls.
yizhang82
added a commit
that referenced
this pull request
Jun 8, 2017
* Support non-virtual calls on interface private members correctly * Support protected methods * Properly handle precode * Throw (tentative) exception when seeing conflict overrides and add a test case (This updates CoreCLR dev/defaultintf the same with the build we are showing at //build)
yizhang82
added a commit
that referenced
this pull request
Jun 9, 2017
* Support non-virtual calls on interface private members correctly * Support protected methods * Properly handle precode * Throw (tentative) exception when seeing conflict overrides and add a test case (This updates CoreCLR dev/defaultintf the same with the build we are showing at //build)
yizhang82
added a commit
that referenced
this pull request
Jun 26, 2017
* Support non-virtual calls on interface private members correctly * Support protected methods * Properly handle precode * Throw (tentative) exception when seeing conflict overrides and add a test case (This updates CoreCLR dev/defaultintf the same with the build we are showing at //build)
yizhang82
added a commit
that referenced
this pull request
Jun 28, 2017
* Support non-virtual calls on interface private members correctly * Support protected methods * Properly handle precode * Throw (tentative) exception when seeing conflict overrides and add a test case (This updates CoreCLR dev/defaultintf the same with the build we are showing at //build)
yizhang82
added a commit
to yizhang82/coreclr
that referenced
this pull request
Jul 10, 2017
* Support non-virtual calls on interface private members correctly * Support protected methods * Properly handle precode * Throw (tentative) exception when seeing conflict overrides and add a test case (This updates CoreCLR dev/defaultintf the same with the build we are showing at //build)
yizhang82
added a commit
that referenced
this pull request
Jul 10, 2017
* Support non-virtual calls on interface private members correctly * Support protected methods * Properly handle precode * Throw (tentative) exception when seeing conflict overrides and add a test case (This updates CoreCLR dev/defaultintf the same with the build we are showing at //build)
yizhang82
added a commit
that referenced
this pull request
Jul 19, 2017
* Support non-virtual calls on interface private members correctly * Support protected methods * Properly handle precode * Throw (tentative) exception when seeing conflict overrides and add a test case (This updates CoreCLR dev/defaultintf the same with the build we are showing at //build)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This updates CoreCLR dev/defaultintf the same with the build we are showing at //build)