New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Unix hosting API on Windows #1295

Merged
merged 1 commit into from Jul 27, 2015

Conversation

Projects
None yet
5 participants
@benpye
Contributor

benpye commented Jul 27, 2015

This fixes #1256 by exposing the new Unix hosting API on Windows. I have not exposed the old hosting API as it only exists on the Unix side for compatibility with dnx. @janvorli

@janvorli

This comment has been minimized.

Show comment
Hide comment
@janvorli

janvorli Jul 27, 2015

Member

LGTM, thanks a lot for making this change.

Member

janvorli commented Jul 27, 2015

LGTM, thanks a lot for making this change.

@jkotas

This comment has been minimized.

Show comment
Hide comment
@jkotas

jkotas Jul 27, 2015

Member

LGTM as well

Member

jkotas commented Jul 27, 2015

LGTM as well

jkotas added a commit that referenced this pull request Jul 27, 2015

@jkotas jkotas merged commit 480227b into dotnet:master Jul 27, 2015

1 check passed

default Build finished. No test results found.
Details
@janvorli

This comment has been minimized.

Show comment
Hide comment
@janvorli

janvorli Jul 27, 2015

Member

@richlander FYI, we have discussed this in the past, now we have the same simple hosting API on Unix and Windows. On Windows, we still support the COM based hosting API.

Member

janvorli commented Jul 27, 2015

@richlander FYI, we have discussed this in the past, now we have the same simple hosting API on Unix and Windows. On Windows, we still support the COM based hosting API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment