Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Arm64] Implement Poison() #13125

Merged
merged 1 commit into from Aug 1, 2017
Merged

[Arm64] Implement Poison() #13125

merged 1 commit into from Aug 1, 2017

Conversation

@sdmaclea
Copy link

@sdmaclea sdmaclea commented Jul 31, 2017

Fixes #13117

@sdmaclea
Copy link
Author

@sdmaclea sdmaclea commented Jul 31, 2017

@parjong @jkotas @dotnet/arm64-contrib PTAL

@@ -1246,7 +1246,8 @@ void UMEntryThunkCode::Encode(BYTE* pTargetCode, void* pvSecretParam)

void UMEntryThunkCode::Poison()
{

// Insert 'brk 0xbe' at the entry point
m_code[0] = 0xd42017c0;
Copy link
Author

@sdmaclea sdmaclea Jul 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@parjong It is not clear to me why none of the Poison() functions call FlushInstructionCache(). I assume you know it is not necessary.

Copy link
Member

@jkotas jkotas Jul 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed here: #12731 (comment)

Copy link
Author

@sdmaclea sdmaclea Aug 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acknowledged

@sdmaclea
Copy link
Author

@sdmaclea sdmaclea commented Aug 1, 2017

@dotnet-bot test Tizen armel Cross Release Build

@sdmaclea
Copy link
Author

@sdmaclea sdmaclea commented Aug 1, 2017

@dotnet-bot test Windows_NT x64 Formatting

@BruceForstall BruceForstall merged commit 040dd03 into dotnet:master Aug 1, 2017
16 checks passed
@sdmaclea sdmaclea deleted the PR-POISON branch Aug 1, 2017
@karelz karelz added this to the 2.1.0 milestone Aug 28, 2017
@karelz karelz added this to the 2.1.0 milestone Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants