This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
fix CoreCLR build errors with clang5.0. #15477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 11, 2017 14:41
MethodContext was already initialized through `new MethodContext();`
the define `#define PAL_EXCEPT(dispositionExpression)` can declare expression that has zero or one param. If it has zero param, then `__param` in the lambda is unused, prevent clang complains by adding this change.
BruceForstall
approved these changes
Dec 11, 2017
jkotas
approved these changes
Dec 11, 2017
stevehayles
added a commit
to stevehayles/meta-dotnetcore
that referenced
this pull request
Dec 24, 2017
New recipe files and revisions primarily to include the fix for issue 15477(dotnet/coreclr#15477)
stevehayles
added a commit
to stevehayles/meta-dotnetcore
that referenced
this pull request
Dec 24, 2017
New recipe files and revisions primarily to include the fix for issue 15477(dotnet/coreclr#15477)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR combines fix for the wrong spmi methodContext explicit constructor and @janvorli's fix for an unused lambda parameter.
With this fixes I was able to build CoreCLR with clang 5.0 on Ubuntu 14.04.
Fix #14757 and #15197.