This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Stop treating all calls to instance interface methods as callvirt#15925
Merged
Conversation
Member
Author
jkotas
reviewed
Jan 19, 2018
| else | ||
| if (pTargetMD->GetMethodTable()->IsInterface() && pTargetMD->IsVirtual()) | ||
| // Backwards compat: calls to abstract interface methods are treated as callvirt | ||
| if (pTargetMD->IsAbstract() && pTargetMD->GetMethodTable()->IsInterface()) |
Member
There was a problem hiding this comment.
IsAbstract is relatively expensive in CoreCLR. Could you please keep the IsInterface check first?
jkotas
approved these changes
Jan 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15827.
I made the test check for
DefaultImplementationsOfInterfacesRuntimeFeature so that we don't need to go and disable it in the release branches.