Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Enablelttng #1598

Merged
merged 1 commit into from Oct 12, 2015
Merged

Enablelttng #1598

merged 1 commit into from Oct 12, 2015

Conversation

ramarag
Copy link
Member

@ramarag ramarag commented Sep 21, 2015

This enables Event logging for the VM

@brianrob @janvorli @sergiy-k : can you take a look

@@ -42,6 +42,7 @@ else()

endif (WIN32)

set(CMAKE_ADDITIONAL_LINKEROPTIONS "" )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please remove the CMAKE_ prefix from the variable name? This prefix is used by cmake for its own variables.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@janvorli
Copy link
Member

@@ -31551,7 +31551,7 @@ void gc_heap::descr_generations_to_profiler (gen_walk_fn fn, void *context)
assert (seg == hp->ephemeral_heap_segment);
assert (curr_gen_number0 <= max_generation);
//
if ((curr_gen_number0 == max_generation))
if (curr_gen_number0 == max_generation)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put this back so that it shows up as no diff (there isn't an actual change here).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, Not unless we want to stop passing -Wparentheses-equality flag to clang compiler.
With the flag this is reported as an error

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha - thanks for the clarification.

@ramarag ramarag force-pushed the enablelttng branch 7 times, most recently from 4fe6749 to c5b0299 Compare September 22, 2015 07:10
@ramarag ramarag force-pushed the enablelttng branch 2 times, most recently from 84f26fa to a882000 Compare September 28, 2015 21:08
@@ -0,0 +1,25 @@
#Event Logging in CoreCLR
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brianrob can you take a look at the event-logging-guide ?

@ramarag ramarag self-assigned this Oct 8, 2015
@brianrob
Copy link
Member

brianrob commented Oct 8, 2015

LGTM. Can you please fix up the CI build errors?

@ramarag ramarag force-pushed the enablelttng branch 5 times, most recently from ca378d1 to 7cd526d Compare October 9, 2015 21:55
@mmitche
Copy link
Member

mmitche commented Oct 9, 2015

@dotnet-bot test this please

@ramarag ramarag force-pushed the enablelttng branch 2 times, most recently from cea1127 to c51bed9 Compare October 12, 2015 01:45
The Tracepoint Providers are built as a separate shared object called libcoreclrtraceptprovider and it is
available in the same directory as libcoreclr.so

By Default the ability of Tracing will not be present
To enable the ability of  Tracing, the apps need to be run like:

LD_PRELOAD=libcoreclrtraceptprovider.so ./corerun HelloWorld.exe

For now to change Xplat Event Logging mechanism add any events to:
        <root>/src/vm/ClrEtwAll.man
Then regenerate files by running :
        <root>/src/inc/genXplatLtnng.pl

Conflicts:
	Documentation/building/linux-instructions.md
ramarag added a commit that referenced this pull request Oct 12, 2015
@ramarag ramarag merged commit 404ab59 into dotnet:master Oct 12, 2015
@ramarag ramarag deleted the enablelttng branch January 7, 2016 22:39
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
8 participants