New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling CLR implemented write watch on AMD64 on Windows. #16516

Merged
merged 1 commit into from Feb 24, 2018

Conversation

Projects
None yet
3 participants
@Maoni0
Member

Maoni0 commented Feb 23, 2018

To keep in sync with Desktop, this enables using CLR implemented write watch on AMD64 on Windows in addition to Linux. Manually managed card bundle will still be using the OS implemented write watch on Windows.

@sywhang @jkotas

@@ -205,10 +205,13 @@ if(CLR_CMAKE_PLATFORM_UNIX_AMD64)
add_definitions(-DFEATURE_UNIX_AMD64_STRUCT_PASSING)
endif (CLR_CMAKE_PLATFORM_UNIX_AMD64)
add_definitions(-DFEATURE_USE_ASM_GC_WRITE_BARRIERS)
if(CLR_CMAKE_PLATFORM_ARCH_AMD64 OR (CLR_CMAKE_PLATFORM_ARCH_ARM64 AND NOT WIN32))

This comment has been minimized.

@jkotas

jkotas Feb 23, 2018

Member

Should we have a bug to enable this for Windows ARM64 as well?

cc @adityamandaleeka

@jkotas

jkotas approved these changes Feb 23, 2018

@Maoni0 Maoni0 added the area-GC label Feb 23, 2018

@Maoni0

This comment has been minimized.

Member

Maoni0 commented Feb 23, 2018

@dotnet-bot test Tizen armel Cross Checked Innerloop Build and Test

@Maoni0 Maoni0 merged commit eeb7a64 into dotnet:master Feb 24, 2018

14 of 15 checks passed

Tizen armel Cross Checked Innerloop Build and Test Build finished.
Details
Alpine.3.6 x64 Debug Build Build finished.
Details
CROSS Check Build finished.
Details
CentOS7.1 x64 Checked Innerloop Build and Test Build finished.
Details
CentOS7.1 x64 Debug Innerloop Build Build finished.
Details
OSX10.12 x64 Checked Innerloop Build and Test Build finished.
Details
Ubuntu arm64 Cross Debug Innerloop Build Build finished.
Details
Ubuntu x64 Checked Innerloop Build and Test Build finished.
Details
Ubuntu x64 Formatting Build finished.
Details
WIP ready for review
Details
Windows_NT x64 Checked Innerloop Build and Test Build finished.
Details
Windows_NT x64 Formatting Build finished.
Details
Windows_NT x86 Checked Innerloop Build and Test Build finished.
Details
Windows_NT x86 Release Innerloop Build and Test Build finished.
Details
license/cla All CLA requirements met.

@AndyAyersMS AndyAyersMS referenced this pull request Mar 11, 2018

Merged

Dictionary CQ #15419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment