/coreclr

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename mscorlib to System.Private.Corelib #17926

Merged
merged 3 commits into from May 9, 2018

Conversation

Reviewers

@jkotas jkotas

@safern safern

Assignees

@maryamariyan maryamariyan

Labels
area-Meta-corelib
Projects
None yet
Milestone
No milestone
4 participants
@maryamariyan @safern @Anipik @jkotas
@maryamariyan
Copy link
Member

maryamariyan commented May 8, 2018 •
edited

cc: @jkotas @safern @danmosemsft

Fixes: #17905

@maryamariyan maryamariyan self-assigned this May 8, 2018

@maryamariyan maryamariyan added the area-Meta-corelib label May 8, 2018

@jkotas

jkotas approved these changes May 8, 2018
View changes

@safern

safern approved these changes May 8, 2018
View changes

@safern

This comment has been minimized.

Sign in to view
Copy link
Member

safern commented May 8, 2018

@Anipik once this is merged we will need to update the mirrors' path to the shared folder
@Anipik

This comment has been minimized.

Sign in to view
Copy link
Member

Anipik commented May 8, 2018

@safern I will do that

@jkotas jkotas merged commit 85374ce into dotnet:master May 9, 2018
19 checks passed

19 checks passed

CROSS Check Build finished.
Details
CentOS7.1 x64 Checked Innerloop Build and Test Build finished.
Details
CentOS7.1 x64 Debug Innerloop Build Build finished.
Details
Linux-musl x64 Debug Build Build finished.
Details
OSX10.12 x64 Checked Innerloop Build and Test Build finished.
Details
Ubuntu arm Cross Checked Innerloop Build and Test Build finished.
Details
Ubuntu arm64 Cross Debug Innerloop Build Build finished.
Details
Ubuntu x64 Checked Innerloop Build and Test Build finished.
Details
Ubuntu x64 Formatting Build finished.
Details
WIP ready for review
Details
Windows_NT x64 Checked Innerloop Build and Test Build finished.
Details
Windows_NT x64 Formatting Build finished.
Details
Windows_NT x64 full_opt ryujit CoreCLR Perf Tests Correctness Build finished.
Details
Windows_NT x64 min_opt ryujit CoreCLR Perf Tests Correctness Build finished.
Details
Windows_NT x86 Checked Innerloop Build and Test Build finished.
Details
Windows_NT x86 Release Innerloop Build and Test Build finished.
Details
Windows_NT x86 full_opt ryujit CoreCLR Perf Tests Correctness Build finished.
Details
Windows_NT x86 min_opt ryujit CoreCLR Perf Tests Correctness Build finished.
Details
license/cla All CLA requirements met.
Details

dotnet-bot added a commit to dotnet/corert that referenced this pull request May 9, 2018

@maryamariyan @dotnet-bot
Rename mscorlib to System.Private.Corelib (dotnet/coreclr#17926) 
* diff from just renaming folder mscorlib to System.Private.CoreLib

* Updating build.proj to reflect name change

Fixes: #17905

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Loading status checks…
f476a45
@Anipik

This comment has been minimized.

Sign in to view
Copy link
Member

Anipik commented May 9, 2018

@safern @maryamariyan I have restarted the mirror for the corefx but for corert it needs some missing commits to be mirrored first. After that I will restart it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment