Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up register preservation requirements for Enter callback #19560

Closed
wants to merge 1 commit into from

Conversation

@noahfalk
Copy link
Member

noahfalk commented Aug 20, 2018

#19023

I'm still testing this, so adding NO_MERGE tag even if CI suggests it is good.

@BruceForstall - PTAL
cc @sergign60

Copy link
Member

BruceForstall left a comment

LGTM. Thanks for the detailed addition to CLR-ABI.

// - volatile floating point registers (xmm4-5)
// - upper halves of ymm registers on AVX (which are volatile)
// - All argument and callee-saved registers must be preserved:
// RDI, RSI, RDX, RCX, R8, R9, RBX, RBP, R12–R15, XMM0, XMM1, XMM2, XMM3, XMM4, XMM5, XMM6, XMM7

This comment has been minimized.

Copy link
@BruceForstall

BruceForstall Aug 20, 2018

Member

The character between R12 and R15 shows up as garbage when I view this in CodeFlow; I wonder if it's some Unicode thing.

@BruceForstall

This comment has been minimized.

Copy link
Member

BruceForstall commented Sep 5, 2018

@noahfalk I presume you're still working on this...

@noahfalk

This comment has been minimized.

Copy link
Member Author

noahfalk commented Sep 5, 2018

I set it down for a while. Eventually I'll get back to it unless someone wants to beat me to it. The remaining work is testing.

@BruceForstall

This comment has been minimized.

Copy link
Member

BruceForstall commented Jan 8, 2019

@noahfalk Just checking... you still expect to get back to it?

@noahfalk

This comment has been minimized.

Copy link
Member Author

noahfalk commented Jan 9, 2019

Good call … I had completely forgotten about this : ) I'd still like to get this in but I should probably be more realistic, it may not be me that does it and it may not be soon. Any particular reason you were asking or just checking on status?

@BruceForstall

This comment has been minimized.

Copy link
Member

BruceForstall commented Jan 9, 2019

Just checking. I've been looking through lots of old issues/PRs seeing if there's old stuff that can be closed.

@BruceForstall

This comment has been minimized.

Copy link
Member

BruceForstall commented Nov 6, 2019

@echesakovMSFT @noahfalk @davmason Is this PR still valid? Presumably at least the CLR-ABI.md changes could be checked in (if they are still correct)?

@echesakovMSFT

This comment has been minimized.

Copy link
Member

echesakovMSFT commented Nov 6, 2019

@BruceForstall I can work on this

@maryamariyan

This comment has been minimized.

Copy link
Member

maryamariyan commented Nov 6, 2019

Thank you for your contribution. As announced in #27549 this repository will be moving to dotnet/runtime on November 13. If you would like to continue working on this PR after this date, the easiest way to move the change to dotnet/runtime is:

  1. In your coreclr repository clone, create patch by running git format-patch origin
  2. In your runtime repository clone, apply the patch by running git apply --directory src/coreclr <path to the patch created in step 1>
@maryamariyan

This comment has been minimized.

Copy link
Member

maryamariyan commented Dec 2, 2019

Thank you for your contribution. As announced in #27549 the dotnet/runtime repository will be used going forward for changes to this code base. Closing this PR as no more changes will be accepted into master for this repository. If you’d like to continue working on this change please move it to dotnet/runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.