Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upClean up register preservation requirements for Enter callback #19560
Conversation
LGTM. Thanks for the detailed addition to CLR-ABI. |
// - volatile floating point registers (xmm4-5) | ||
// - upper halves of ymm registers on AVX (which are volatile) | ||
// - All argument and callee-saved registers must be preserved: | ||
// RDI, RSI, RDX, RCX, R8, R9, RBX, RBP, R12–R15, XMM0, XMM1, XMM2, XMM3, XMM4, XMM5, XMM6, XMM7 |
This comment has been minimized.
This comment has been minimized.
BruceForstall
Aug 20, 2018
Member
The character between R12 and R15 shows up as garbage when I view this in CodeFlow; I wonder if it's some Unicode thing.
This comment has been minimized.
This comment has been minimized.
@noahfalk I presume you're still working on this... |
This comment has been minimized.
This comment has been minimized.
I set it down for a while. Eventually I'll get back to it unless someone wants to beat me to it. The remaining work is testing. |
This comment has been minimized.
This comment has been minimized.
@noahfalk Just checking... you still expect to get back to it? |
This comment has been minimized.
This comment has been minimized.
Good call … I had completely forgotten about this : ) I'd still like to get this in but I should probably be more realistic, it may not be me that does it and it may not be soon. Any particular reason you were asking or just checking on status? |
This comment has been minimized.
This comment has been minimized.
Just checking. I've been looking through lots of old issues/PRs seeing if there's old stuff that can be closed. |
This comment has been minimized.
This comment has been minimized.
@echesakovMSFT @noahfalk @davmason Is this PR still valid? Presumably at least the CLR-ABI.md changes could be checked in (if they are still correct)? |
This comment has been minimized.
This comment has been minimized.
@BruceForstall I can work on this |
This comment has been minimized.
This comment has been minimized.
Thank you for your contribution. As announced in #27549 this repository will be moving to dotnet/runtime on November 13. If you would like to continue working on this PR after this date, the easiest way to move the change to dotnet/runtime is:
|
This comment has been minimized.
This comment has been minimized.
Thank you for your contribution. As announced in #27549 the dotnet/runtime repository will be used going forward for changes to this code base. Closing this PR as no more changes will be accepted into master for this repository. If you’d like to continue working on this change please move it to dotnet/runtime. |
noahfalk commentedAug 20, 2018
#19023
I'm still testing this, so adding NO_MERGE tag even if CI suggests it is good.
@BruceForstall - PTAL
cc @sergign60