diff --git a/src/jit/flowgraph.cpp b/src/jit/flowgraph.cpp index d03c6e379ab6..18e663f91b90 100644 --- a/src/jit/flowgraph.cpp +++ b/src/jit/flowgraph.cpp @@ -18685,10 +18685,10 @@ void Compiler::fgSetTreeSeqHelper(GenTree* tree, bool isLIR) break; case GT_INDEX_ADDR: - // Evaluate the index first, then the array address - assert((tree->gtFlags & GTF_REVERSE_OPS) != 0); - fgSetTreeSeqHelper(tree->AsIndexAddr()->Index(), isLIR); + // Evaluate the array first, then the index.... + assert((tree->gtFlags & GTF_REVERSE_OPS) == 0); fgSetTreeSeqHelper(tree->AsIndexAddr()->Arr(), isLIR); + fgSetTreeSeqHelper(tree->AsIndexAddr()->Index(), isLIR); break; default: diff --git a/src/jit/gentree.h b/src/jit/gentree.h index 12bb9aaed8e9..e7e1a32bf30c 100644 --- a/src/jit/gentree.h +++ b/src/jit/gentree.h @@ -4257,8 +4257,7 @@ struct GenTreeIndexAddr : public GenTreeOp gtFlags |= GTF_INX_RNGCHK; } - // REVERSE_OPS is set because we must evaluate the index before the array address. - gtFlags |= GTF_EXCEPT | GTF_GLOB_REF | GTF_REVERSE_OPS; + gtFlags |= GTF_EXCEPT | GTF_GLOB_REF; } #if DEBUGGABLE_GENTREE diff --git a/tests/src/JIT/Regression/JitBlue/GitHub_20040/GitHub_20040.cs b/tests/src/JIT/Regression/JitBlue/GitHub_20040/GitHub_20040.cs new file mode 100644 index 000000000000..4403273cd9c2 --- /dev/null +++ b/tests/src/JIT/Regression/JitBlue/GitHub_20040/GitHub_20040.cs @@ -0,0 +1,58 @@ +// Licensed to the .NET Foundation under one or more agreements. +// The .NET Foundation licenses this file to you under the MIT license. +// See the LICENSE file in the project root for more information. + +using System; + +// GitHub 20040: operand ordering bug with GT_INDEX_ADDR +// Requires minopts/tier0 to repro + +namespace GitHub_20040 +{ + class Program + { + static int Main(string[] args) + { + var array = new byte[] {0x00, 0x01}; + var reader = new BinaryTokenStreamReader(array); + + var val = reader.ReadByte(); + + if (val == 0x01) + { + Console.WriteLine("Pass"); + return 100; + } + else + { + Console.WriteLine($"Fail: val=0x{val:x2}, expected 0x01"); + return 0; + } + } + } + + public class BinaryTokenStreamReader + { + private readonly byte[] currentBuffer; + + public BinaryTokenStreamReader(byte[] input) + { + this.currentBuffer = input; + } + + byte[] CheckLength(out int offset) + { + // In the original code, this logic is more complicated. + // It's simplified here to demonstrate the bug. + offset = 1; + return currentBuffer; + } + + public byte ReadByte() + { + int offset; + var buff = CheckLength(out offset); + return buff[offset]; + } + } +} diff --git a/tests/src/JIT/Regression/JitBlue/GitHub_20040/GitHub_20040.csproj b/tests/src/JIT/Regression/JitBlue/GitHub_20040/GitHub_20040.csproj new file mode 100644 index 000000000000..e191e01217e9 --- /dev/null +++ b/tests/src/JIT/Regression/JitBlue/GitHub_20040/GitHub_20040.csproj @@ -0,0 +1,34 @@ + + + + + Debug + AnyCPU + $(MSBuildProjectName) + 2.0 + {95DFC527-4DC1-495E-97D7-E94EE1F7140D} + Exe + {786C830F-07A1-408B-BD7F-6EE04809D6DB};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC} + ..\..\ + + + + + + + False + + + + None + True + + + + + + + + + +