New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strlen to managed code and vectorize #21729

Merged
merged 4 commits into from Jan 2, 2019

Conversation

Projects
None yet
2 participants
@benaadams
Copy link
Collaborator

benaadams commented Dec 31, 2018

Follow up to #21720

/cc @jkotas

Contributes to dotnet/corefx#34283 (comment)

@benaadams benaadams referenced this pull request Dec 31, 2018

Merged

Improve MdUtf8String #21720

@jkotas

This comment has been minimized.

Copy link
Member

jkotas commented Dec 31, 2018

Build breaks ... this needs updating in https://github.com/dotnet/coreclr/blob/master/src/vm/mscorlib.h#L957 too. Change SM_PtrSByt_RetInt to SM_PtrByte_RetInt and also make the matching change for SM_PtrSByt_RetInt in metasig.h.

@jkotas

This comment has been minimized.

Copy link
Member

jkotas commented Dec 31, 2018

You can replace Win32Native.lstrlenA and Win32Native.lstrlenW` with the managed implementation too while you are on it.

@benaadams

This comment has been minimized.

Copy link
Collaborator Author

benaadams commented Dec 31, 2018

Will do a follow up PR for lstrlenW and wcslen

@benaadams benaadams referenced this pull request Dec 31, 2018

Closed

Vectorize wcslen #21730

@jkotas

jkotas approved these changes Jan 1, 2019

Copy link
Member

jkotas left a comment

Thanks!

@jkotas

This comment has been minimized.

Copy link
Member

jkotas commented Jan 1, 2019

@dotnet-bot test Ubuntu x64 Checked CoreFX Tests please
@dotnet-bot test Windows_NT x64 Checked CoreFX Tests please

@benaadams

This comment has been minimized.

Copy link
Collaborator Author

benaadams commented Jan 1, 2019

👍

@jkotas jkotas merged commit 4a7a204 into dotnet:master Jan 2, 2019

30 checks passed

CentOS7.1 x64 Checked Innerloop Build and Test Build finished.
Details
CentOS7.1 x64 Debug Innerloop Build Build finished.
Details
Linux-musl x64 Debug Build Build finished.
Details
OSX10.12 x64 Checked Innerloop Build and Test Build finished.
Details
Tizen armel Cross Checked Innerloop Build and Test Build finished.
Details
Ubuntu arm Cross Checked Innerloop Build and Test Build finished.
Details
Ubuntu arm Cross Checked crossgen_comparison Build and Test Build finished.
Details
Ubuntu arm Cross Checked no_tiered_compilation_innerloop Build and Test Build finished.
Details
Ubuntu arm Cross Release crossgen_comparison Build and Test Build finished.
Details
Ubuntu x64 Checked CoreFX Tests Build finished.
Details
Ubuntu x64 Checked Innerloop Build and Test Build finished.
Details
Ubuntu x64 Checked Innerloop Build and Test (Jit - TieredCompilation=0) Build finished.
Details
Ubuntu x64 Formatting Build finished.
Details
Ubuntu16.04 arm64 Cross Checked Innerloop Build and Test Build finished.
Details
Ubuntu16.04 arm64 Cross Checked no_tiered_compilation_innerloop Build and Test Build finished.
Details
Windows_NT arm Cross Debug Innerloop Build Build finished.
Details
Windows_NT arm64 Cross Debug Innerloop Build Build finished.
Details
Windows_NT x64 Checked CoreFX Tests Build finished.
Details
Windows_NT x64 Checked Innerloop Build and Test Build finished.
Details
Windows_NT x64 Checked Innerloop Build and Test (Jit - TieredCompilation=0) Build finished.
Details
Windows_NT x64 Formatting Build finished.
Details
Windows_NT x64 Release CoreFX Tests Build finished.
Details
Windows_NT x64 full_opt ryujit CoreCLR Perf Tests Correctness Build finished.
Details
Windows_NT x64 min_opt ryujit CoreCLR Perf Tests Correctness Build finished.
Details
Windows_NT x86 Checked Innerloop Build and Test Build finished.
Details
Windows_NT x86 Checked Innerloop Build and Test (Jit - TieredCompilation=0) Build finished.
Details
Windows_NT x86 Release Innerloop Build and Test Build finished.
Details
Windows_NT x86 full_opt ryujit CoreCLR Perf Tests Correctness Build finished.
Details
Windows_NT x86 min_opt ryujit CoreCLR Perf Tests Correctness Build finished.
Details
license/cla All CLA requirements met.
Details

Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/corefx that referenced this pull request Jan 2, 2019

strlen to managed code and vectorize (dotnet/coreclr#21729)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/corert that referenced this pull request Jan 2, 2019

strlen to managed code and vectorize (dotnet/coreclr#21729)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

jkotas added a commit to dotnet/corefx that referenced this pull request Jan 2, 2019

strlen to managed code and vectorize (dotnet/coreclr#21729)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

jkotas added a commit to dotnet/corert that referenced this pull request Jan 2, 2019

strlen to managed code and vectorize (dotnet/coreclr#21729)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/mono that referenced this pull request Jan 2, 2019

strlen to managed code and vectorize (dotnet/coreclr#21729)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

marek-safar added a commit to mono/mono that referenced this pull request Jan 2, 2019

strlen to managed code and vectorize (dotnet/coreclr#21729)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

@benaadams benaadams deleted the benaadams:strlen branch Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment