Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the double/float formatters to return the shortest roundtrippable string. #22040

merged 15 commits into from Feb 1, 2019

Responding to various feedback from the PR

Select commit
Updating Number.Formatting to always compute a round-trippable number…
tannergooding Jan 15, 2019
Adding a third-party notice entry for the Grisu3 reference implementa…
tannergooding Jan 16, 2019
Fixing up the Grisu3 algorithm to better match the reference implemen…
tannergooding Jan 17, 2019
Porting the Grisu3 implementation that generates the shortest roundtr…
tannergooding Jan 17, 2019
Updating the Dragon4 algorithm to support printing the shortest round…
tannergooding Jan 17, 2019
Fixing the double/float formatters to ignore precision specifiers for…
tannergooding Jan 17, 2019
Fixing the double/float formatters to handle +0.0 and -0.0
tannergooding Jan 17, 2019
Fix the casing of `point` in THIRD-PARTY-NOTICES
jkotas Jan 17, 2019
Fixing the double/float formatting code to consider a precision speci…
tannergooding Jan 18, 2019
Fixing the double/float formatter so that nMaxDigits is set appropria…
tannergooding Jan 24, 2019
Changing the double/float formatting logic to account for the format …
tannergooding Jan 25, 2019
Updating the double/float formatter to take the format specifier into…
tannergooding Jan 26, 2019
Fixing the double/float formatting code to continue handling zero cor…
tannergooding Jan 26, 2019
Disabling some outdated CoreFX tests.
tannergooding Jan 28, 2019
Responding to various feedback from the PR
tannergooding Jan 31, 2019
WIP / WIP successful Feb 1, 2019 in 1s

Ready for review

No match found based on configuration


By default, WIP only checks the pull request title for the terms "WIP", "Work in progress" and "🚧".

You can configure both the terms and the location that the WIP app will look for by signing up for the pro plan: All revenue will be donated to Rails Girls Summer of Code.

You can’t perform that action at this time.