Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Throw the right exception when interface dispatch is ambiguous#22295

Merged
MichalStrehovsky merged 3 commits intodotnet:masterfrom
MichalStrehovsky:resolutionException
Feb 3, 2019
Merged

Throw the right exception when interface dispatch is ambiguous#22295
MichalStrehovsky merged 3 commits intodotnet:masterfrom
MichalStrehovsky:resolutionException

Conversation

@MichalStrehovsky
Copy link
Copy Markdown
Member

@MichalStrehovsky MichalStrehovsky commented Jan 30, 2019

Throw the approved exception per dotnet/corefx#34124.

@MichalStrehovsky
Throw the right exception when interface dispatch is ambiguous
bad0f3b 
Throw the approved exception per dotnet/corefx#34124.
@MichalStrehovsky
Copy link
Copy Markdown
Member Author

MichalStrehovsky commented Jan 30, 2019

Cc @sergiy-k

@jkotas
Copy link
Copy Markdown
Member

jkotas commented Jan 30, 2019

Do we need to update tests to check for this?

@MichalStrehovsky MichalStrehovsky added the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Jan 30, 2019
@MichalStrehovsky
Copy link
Copy Markdown
Member Author

MichalStrehovsky commented Jan 30, 2019

Do we need to update tests to check for this?

My plan was to find the test that fails and fix that one (I don't know where are the tests for this is, but I know we have at least one). If nothing fails in the CI, I'll go dig it out.

@MichalStrehovsky MichalStrehovsky removed the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Feb 1, 2019
@MichalStrehovsky
Copy link
Copy Markdown
Member Author

MichalStrehovsky commented Feb 1, 2019

Windows_NT x64 Checked CoreFX Tests fails with:

Starting:    System.Text.Encoding.Tests

Assert failure(PID 8936 [0x000022e8], Thread: 2724 [0x0aa4]): Precondition failure: FAILED: pParentData == 0 || (pMT->ParentEquals(pParentData->GetDeclMethodTable()) && pMT->ParentEquals(pParentData->GetImplMethodTable()))

CORECLR! CHECK::Trigger + 0x2C4 (0x00007ffb`c957cf94)
CORECLR! MethodTable::MethodDataObject::Init + 0x67A (0x00007ffb`c9a5cc02)
CORECLR! MethodTable::GetMethodDataHelper + 0x642 (0x00007ffb`c9a53d0a)
CORECLR! MethodTable::GetMethodData + 0xDE (0x00007ffb`c9a53126)
CORECLR! MethodTable::MethodIterator::Init + 0x3CB (0x00007ffb`c9a5d01b)
CORECLR! MethodTable::MethodIterator::MethodIterator + 0x11 (0x00007ffb`c9a3d321)
CORECLR! MethodTableBuilder::ImportParentMethods + 0x137 (0x00007ffb`c9c395fb)
CORECLR! MethodTableBuilder::BuildMethodTableThrowing + 0x14AD (0x00007ffb`c9c28111)
CORECLR! ClassLoader::CreateTypeHandleForTypeDefThrowing + 0x113F (0x00007ffb`c9c2dffb)
CORECLR! ClassLoader::CreateTypeHandleForTypeKey + 0x444 (0x00007ffb`c979eb98)
    File: d:\j\workspace\x64_checked_w---43686a05\src\vm\methodtable.cpp Line: 8447
    Image: D:\j\workspace\x64_checked_w---43686a05\bin\tests\Windows_NT.x64.Checked\testhost\dotnet.exe

Finished:    System.Net.Http.Functional.Tests

Is this known?

@jkotas
Copy link
Copy Markdown
Member

jkotas commented Feb 1, 2019

I have not seen this before.

@MichalStrehovsky
Copy link
Copy Markdown
Member Author

MichalStrehovsky commented Feb 2, 2019

@dotnet-bot test Windows_NT x64 Checked CoreFX Tests

@MichalStrehovsky
Copy link
Copy Markdown
Member Author

MichalStrehovsky commented Feb 3, 2019

I have not seen this before.

Seems intermittent. FWIW, filed #22382. I don't see how it could be related/caused by this check in.

@MichalStrehovsky MichalStrehovsky merged commit bbd7905 into dotnet:master Feb 3, 2019
@MichalStrehovsky MichalStrehovsky deleted the resolutionException branch February 3, 2019 18:22
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@MichalStrehovsky
Throw the right exception when interface dispatch is ambiguous (dotne…
c46a1ec 
…t/coreclr#22295)

Throw the approved exception per dotnet/corefxdotnet/coreclr#34124.


Commit migrated from dotnet/coreclr@bbd7905
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@stephentoub stephentoub stephentoub approved these changes

@jkotas jkotas jkotas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MichalStrehovsky @jkotas @stephentoub