Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delegate creation for default interface methods on structs #22427

Merged
merged 1 commit into from Feb 7, 2019

Conversation

MichalStrehovsky
Copy link
Member

@MichalStrehovsky MichalStrehovsky commented Feb 5, 2019

We only need to find an unboxing stub if we resolved the interface to a valuetype method. If we resolved to a default interface method implementation, unboxing is not necessary.

Fixes #22386.

We only need to find an unboxing stub if we resolved the interface to a valuetype method. If we resolved to a default interface method implementation, unboxing is not necessary.
@MichalStrehovsky MichalStrehovsky added this to the 3.0 milestone Feb 5, 2019
Copy link
Member

@davidwrighton davidwrighton left a comment

This looks good

@MichalStrehovsky
Copy link
Member Author

MichalStrehovsky commented Feb 6, 2019

@dotnet-bot test OSX10.12 x64 Checked Innerloop Build and Test

@MichalStrehovsky
Copy link
Member Author

MichalStrehovsky commented Feb 7, 2019

Cc @sergiy-k

@MichalStrehovsky MichalStrehovsky merged commit ef48a43 into dotnet:master Feb 7, 2019
27 checks passed
@MichalStrehovsky MichalStrehovsky deleted the fix22386 branch Feb 7, 2019
picenka21 pushed a commit to picenka21/runtime that referenced this issue Feb 18, 2022
…t/coreclr#22427)

We only need to find an unboxing stub if we resolved the interface to a valuetype method. If we resolved to a default interface method implementation, unboxing is not necessary.

Commit migrated from dotnet/coreclr@ef48a43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants