Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Add Large pages support in GC #23251
I'm thinking if a better error message should be presented if
But maybe we could tackle it in the host or CLI?
@mjsabby one thing I missed was we should simply not do anything for
I have to introduce
@Maoni0 What are your thoughts on hard limit + numa awareness + now large pages? I'm thinking to start with we keep Large Pages NUMA-unaware, otherwise it gets a bit complicated where and how much should the memory be split and commuted at startup. Already the multiple heaps overcommits by 3X I think.
For 3.0 maybe we start with GCHardLimit + Large Pages does a 3X overcommit at startup then in the future we add configs for splitting the memory across LOH, SOH + NUMA Nodes?
this sounds fine to me if it's fine with you since you are our 1st customer for this :) also I'm working on reducing this 3x to 2x.
most likely we wouldn't need another config - it'll just be improved naturally in the future versions.
4 times, most recently
Mar 29, 2019
This is ready for review again.
After this change, the situation will be:
Next up will be Large Pages support for the GC Heap on Linux.
(1) Noting that GCHeapHardLimit is required (GCHeapHardLimit takes input as hex bytes)