Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ubuntu arm build break. #23270

Merged
merged 3 commits into from Mar 15, 2019

Conversation

Projects
None yet
2 participants
@jkoritzinsky
Copy link
Member

jkoritzinsky commented Mar 15, 2019

Add platformdefines.h include to fix build break.

Fixes #23268

@jkoritzinsky jkoritzinsky deleted the jkoritzinsky:cdecl-fix branch Mar 15, 2019

@AaronRobinsonMSFT

This comment has been minimized.

Copy link
Member

AaronRobinsonMSFT commented Mar 15, 2019

@jkoritzinsky Thanks. Actually submit this one as well. If the PR passes before the other we can merge this one instead. I would prefer for this to be the fix since it is what I will do tomorrow anyways.

@jkoritzinsky jkoritzinsky restored the jkoritzinsky:cdecl-fix branch Mar 15, 2019

@jkoritzinsky jkoritzinsky reopened this Mar 15, 2019

@jkoritzinsky

This comment has been minimized.

Copy link
Member Author

jkoritzinsky commented Mar 15, 2019

@dotnet-bot test this please

@AaronRobinsonMSFT

This comment has been minimized.

Copy link
Member

AaronRobinsonMSFT commented Mar 15, 2019

Let the race begin! - #23269

@AaronRobinsonMSFT

This comment has been minimized.

Copy link
Member

AaronRobinsonMSFT commented Mar 15, 2019

All builds pass in Azure piplines. OSX release passed without issues, but OSX debug had an issue in the pipline due to logs.

Artifact build_OSX_x64_checked_Logs already exists for build 124917.

This is the preferable fix so I am commiting this one in lieu of #23269.

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit 68fad02 into dotnet:master Mar 15, 2019

11 of 24 checks passed

OSX10.12 x64 Checked Innerloop Build and Test Triggered. (28/54 on osx-10.12||OSX.1012.Amd64.Open)
Details
Ubuntu arm Cross Checked Innerloop Build and Test Started.
Details
Ubuntu arm Cross Checked crossgen_comparison Build and Test Started.
Details
Ubuntu arm Cross Checked no_tiered_compilation_innerloop Build and Test Started.
Details
Ubuntu arm Cross Release crossgen_comparison Build and Test Started.
Details
Windows_NT x64 Checked CoreFX Tests Triggered. (181/325 on win2012-20180911)
Details
Windows_NT x64 Checked Innerloop Build and Test Triggered. (184/325 on win2012-20180911)
Details
Windows_NT x64 Checked Innerloop Build and Test (Jit - TieredCompilation=0) Triggered. (185/325 on win2012-20180911)
Details
Windows_NT x64 Formatting Triggered. (183/325 on win2012-20180911)
Details
Windows_NT x64 Release CoreFX Tests Triggered. (186/325 on win2012-20180911)
Details
Windows_NT x86 Checked Innerloop Build and Test Triggered. (180/325 on win2012-20180911)
Details
Windows_NT x86 Checked Innerloop Build and Test (Jit - TieredCompilation=0) Triggered. (187/325 on win2012-20180911)
Details
Windows_NT x86 Release Innerloop Build and Test Triggered. (182/325 on win2012-20180911)
Details
CentOS7.1 x64 Checked Innerloop Build and Test Build finished.
Details
CentOS7.1 x64 Debug Innerloop Build Build finished.
Details
Ubuntu x64 Checked CoreFX Tests Build finished.
Details
Ubuntu x64 Checked Innerloop Build and Test Build finished.
Details
Ubuntu x64 Checked Innerloop Build and Test (Jit - TieredCompilation=0) Build finished.
Details
Ubuntu x64 Formatting Build finished.
Details
Windows_NT x64 full_opt ryujit CoreCLR Perf Tests Correctness Build finished.
Details
Windows_NT x64 min_opt ryujit CoreCLR Perf Tests Correctness Build finished.
Details
Windows_NT x86 full_opt ryujit CoreCLR Perf Tests Correctness Build finished.
Details
Windows_NT x86 min_opt ryujit CoreCLR Perf Tests Correctness Build finished.
Details
license/cla All CLA requirements met.
Details

@jkoritzinsky jkoritzinsky deleted the jkoritzinsky:cdecl-fix branch Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.