This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Allow reabstraction of default interface methods#23313
Merged
MichalStrehovsky merged 8 commits intodotnet:masterfrom Apr 8, 2019
Merged
Allow reabstraction of default interface methods#23313MichalStrehovsky merged 8 commits intodotnet:masterfrom
MichalStrehovsky merged 8 commits intodotnet:masterfrom
Conversation
MichalStrehovsky
added
the
* NO MERGE *
Member
We may consider throwing |
MichalStrehovsky
removed
the
* NO MERGE *
davidwrighton
approved these changes
Apr 5, 2019
Member
Author
|
@dotnet-bot test Ubuntu x64 Checked CoreFX Tests |
1 similar comment
Member
Author
|
@dotnet-bot test Ubuntu x64 Checked CoreFX Tests |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Allow the runtime to load types with incomplete interface implementations. With this change, we allow (in pseudo-C#):
```csharp
interface IFoo { void Frob() { } }
interface IBar : IFoo { abstract void IFoo.Frob() }
class Fooer : IBar { }
```
Calling IFoo.Frob on an instance of `Fooer` will result in new exception being thrown because the default implementation of `IFoo.Frob` was re-abstracted by `IBar`.
Commit migrated from dotnet/coreclr@24c92a5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the runtime to load types with incomplete interface implementations. With this change, we allow (in pseudo-C#):
Calling IFoo.Frob on an instance of
Fooerwill result in new exception being thrown because the default implementation ofIFoo.Frobwas re-abstracted byIBar.