This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Nullable: make Object.ToString() return nullable #23510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
safern
commented
Mar 28, 2019
src/System.Private.CoreLib/shared/System/Globalization/HijriCalendar.Win32.cs
Show resolved
Hide resolved
|
I thought we went with saying |
stephentoub
reviewed
Mar 28, 2019
src/System.Private.CoreLib/shared/System/String.Manipulation.cs
Outdated
Show resolved
Hide resolved
safern
force-pushed
the
ObjectToString
branch
2 times, most recently
from
5831a1b to
eebcec5
Compare
jkotas
reviewed
Mar 28, 2019
src/System.Private.CoreLib/shared/System/String.Manipulation.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Mar 28, 2019
safern
force-pushed
the
NullableFeature
branch
3 times, most recently
from
c01bfd0 to
652234c
Compare
stephentoub
approved these changes
Mar 28, 2019
|
Will hold this PR until we come to the final decision on whether we should make its return type nullable or not. |
|
Actually spoke with @stephentoub offline, will merge, since discussions are going on and we need to discuss more to come to a final decision. Since returning nullable was the behavior before turning on the switch, I'm going to merge and we can revisit if needed after the meeting. |
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/corefx
that referenced
this pull request
Apr 5, 2019
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
stephentoub
pushed a commit
to dotnet/corefx
that referenced
this pull request
Apr 6, 2019
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/corert
that referenced
this pull request
Apr 9, 2019
Signed-off-by: dotnet-bot <anirudhagnihotry098@gmail.com>
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/corert
that referenced
this pull request
Apr 9, 2019
Signed-off-by: dotnet-bot <anirudhagnihotry098@gmail.com>
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/mono
that referenced
this pull request
Apr 9, 2019
Signed-off-by: dotnet-bot <anirudhagnihotry098@gmail.com>
Anipik
pushed a commit
to Dotnet-GitSync-Bot/corert
that referenced
this pull request
Apr 9, 2019
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas
pushed a commit
to dotnet/corert
that referenced
this pull request
Apr 10, 2019
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@krwq with this warn disabled you should be able to now annotate overrides correctly, the ones you had to workaround in you previous PRs.
cc: @jaredpar @jcouv @terrajobst