Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullable: make Object.ToString() return nullable #23510

Merged
merged 1 commit into from Mar 28, 2019

Conversation

safern
Copy link
Member

@safern safern commented Mar 28, 2019

@krwq with this warn disabled you should be able to now annotate overrides correctly, the ones you had to workaround in you previous PRs.

cc: @jaredpar @jcouv @terrajobst

@terrajobst
Copy link
Member

@terrajobst terrajobst commented Mar 28, 2019

I thought we went with saying object.ToString() should be non-null. What changed?

@stephentoub
Copy link
Member

@stephentoub stephentoub commented Mar 28, 2019

#23466 (comment)

@safern safern force-pushed the ObjectToString branch 2 times, most recently from 5831a1b to eebcec5 Compare Mar 28, 2019
@safern
Copy link
Member Author

@safern safern commented Mar 28, 2019

Will hold this PR until we come to the final decision on whether we should make its return type nullable or not.

@safern
Copy link
Member Author

@safern safern commented Mar 28, 2019

Actually spoke with @stephentoub offline, will merge, since discussions are going on and we need to discuss more to come to a final decision. Since returning nullable was the behavior before turning on the switch, I'm going to merge and we can revisit if needed after the meeting.

@safern safern merged commit 1cdbdb0 into dotnet:NullableFeature Mar 28, 2019
6 checks passed
@safern safern deleted the ObjectToString branch Mar 28, 2019
Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/corefx that referenced this issue Apr 5, 2019
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
stephentoub pushed a commit to dotnet/corefx that referenced this issue Apr 6, 2019
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/corert that referenced this issue Apr 9, 2019
Signed-off-by: dotnet-bot <anirudhagnihotry098@gmail.com>
Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/corert that referenced this issue Apr 9, 2019
Signed-off-by: dotnet-bot <anirudhagnihotry098@gmail.com>
Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/mono that referenced this issue Apr 9, 2019
Signed-off-by: dotnet-bot <anirudhagnihotry098@gmail.com>
Anipik pushed a commit to Dotnet-GitSync-Bot/corert that referenced this issue Apr 9, 2019
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas pushed a commit to dotnet/corert that referenced this issue Apr 10, 2019
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
filipnavara pushed a commit to filipnavara/mono that referenced this issue Apr 11, 2019
Signed-off-by: dotnet-bot <anirudhagnihotry098@gmail.com>
picenka21 pushed a commit to picenka21/runtime that referenced this issue Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants