New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nullable: make Object.ToString() return nullable #23510
Conversation
src/System.Private.CoreLib/shared/System/Globalization/HijriCalendar.Win32.cs
Show resolved
Hide resolved
I thought we went with saying |
src/System.Private.CoreLib/shared/System/String.Manipulation.cs
Outdated
Show resolved
Hide resolved
5831a1b
to
eebcec5
Compare
src/System.Private.CoreLib/shared/System/String.Manipulation.cs
Outdated
Show resolved
Hide resolved
c01bfd0
to
652234c
Compare
Will hold this PR until we come to the final decision on whether we should make its return type nullable or not. |
Actually spoke with @stephentoub offline, will merge, since discussions are going on and we need to discuss more to come to a final decision. Since returning nullable was the behavior before turning on the switch, I'm going to merge and we can revisit if needed after the meeting. |
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot <anirudhagnihotry098@gmail.com>
Signed-off-by: dotnet-bot <anirudhagnihotry098@gmail.com>
Signed-off-by: dotnet-bot <anirudhagnihotry098@gmail.com>
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot <anirudhagnihotry098@gmail.com>
@krwq with this warn disabled you should be able to now annotate overrides correctly, the ones you had to workaround in you previous PRs.
cc: @jaredpar @jcouv @terrajobst