Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clr-configuration-knobs and cleanups #24016

Merged
merged 1 commit into from Apr 16, 2019

Conversation

Projects
None yet
2 participants
@am11
Copy link
Contributor

am11 commented Apr 15, 2019

  • Remove obsolete comment from tests/src/GC/Scenarios/Samples/gc.cs (based on #23595)
  • In the C# script clr-configuration-knobs.csx, update the usage to use dotnet-script tool as dotnet-csi and other repl commands were removed. The new bring up might happen by the Roslyn team: dotnet/roslyn#17666. Meanwhile, dotnet-script can be installed using: dotnet tool install --global dotnet-script.
  • Remove extra spaces from end of markdown table rows.

/cc @jkotas

@am11 am11 force-pushed the am11:update-knobs branch from 1cb132b to 5375a52 Apr 15, 2019

@jkotas

jkotas approved these changes Apr 15, 2019

Copy link
Member

jkotas left a comment

Thanks

@jkotas

This comment has been minimized.

Copy link
Member

jkotas commented Apr 15, 2019

@jkotas jkotas merged commit ee2c5d6 into dotnet:master Apr 16, 2019

10 of 12 checks passed

Ubuntu arm Cross Checked crossgen_comparison Build and Test Started.
Details
Ubuntu arm Cross Release crossgen_comparison Build and Test Started.
Details
Ubuntu x64 Checked CoreFX Tests Build finished.
Details
Ubuntu x64 Formatting Build finished.
Details
Windows_NT x64 Checked CoreFX Tests Build finished.
Details
Windows_NT x64 Formatting Build finished.
Details
Windows_NT x64 Release CoreFX Tests Build finished.
Details
Windows_NT x64 full_opt ryujit CoreCLR Perf Tests Correctness Build finished.
Details
Windows_NT x64 min_opt ryujit CoreCLR Perf Tests Correctness Build finished.
Details
Windows_NT x86 full_opt ryujit CoreCLR Perf Tests Correctness Build finished.
Details
Windows_NT x86 min_opt ryujit CoreCLR Perf Tests Correctness Build finished.
Details
license/cla All CLA requirements met.
Details

@am11 am11 deleted the am11:update-knobs branch Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.