Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NewArrayHolder for array types #24017

Merged
merged 1 commit into from Apr 16, 2019

Conversation

Projects
None yet
2 participants
@omajid
Copy link
Member

omajid commented Apr 15, 2019

This touches all the code outside of src/debug/.

Using a NewHolder with array types means that when the holder is ready to release the memory, it ends up invoking delete (instead of delete[]) on that array. This is an undefined behaviour.

Use NewArrayHolder instead to fix this.

Use NewArrayHolder for array types
This touches all the code outside of src/debug/.

Using a NewHolder with array types means that when the holder is ready
to release the memory, it ends up invoking `delete` (instead of
`delete[]`) on that array. This is an undefined behaviour.

Use NewArrayHolder instead to fix this.
@jkotas

jkotas approved these changes Apr 16, 2019

Copy link
Member

jkotas left a comment

Thanks

@jkotas jkotas merged commit 0f838a7 into dotnet:master Apr 16, 2019

12 checks passed

Ubuntu arm Cross Checked crossgen_comparison Build and Test Build finished.
Details
Ubuntu arm Cross Release crossgen_comparison Build and Test Build finished.
Details
Ubuntu x64 Checked CoreFX Tests Build finished.
Details
Ubuntu x64 Formatting Build finished.
Details
Windows_NT x64 Checked CoreFX Tests Build finished.
Details
Windows_NT x64 Formatting Build finished.
Details
Windows_NT x64 Release CoreFX Tests Build finished.
Details
Windows_NT x64 full_opt ryujit CoreCLR Perf Tests Correctness Build finished.
Details
Windows_NT x64 min_opt ryujit CoreCLR Perf Tests Correctness Build finished.
Details
Windows_NT x86 full_opt ryujit CoreCLR Perf Tests Correctness Build finished.
Details
Windows_NT x86 min_opt ryujit CoreCLR Perf Tests Correctness Build finished.
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.