This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
[System.Globalization.Native] Fix performance regression on glibc on Linux #24099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw, realistically there's only 32 different variations of CompareOptions that generate different collators. Using a binary search tree for that looks like quite an overkill. I plan to address that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/aspnetcore#9404, caused by #22390.
Running the tsearch vs. tfind test code on Ubuntu in Azure resulted in 18% performance improvement in favour of running
tfindfirst and only usingtsearchas fallback. On macOS the performance is nearly identical./cc @janvorli @stephentoub