This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Add Medium GC Profiling & ICorProfilerInfo::GetObjectReferences #24156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davmason
approved these changes
Apr 22, 2019
mjsabby
force-pushed
the
profilerGetObjectReferences
branch
from
6f7d712
to
768ceb1
Compare
Maoni0
reviewed
Apr 23, 2019
mjsabby
force-pushed
the
profilerGetObjectReferences
branch
2 times, most recently
from
d2d1ff2
to
09a37fe
Compare
mjsabby
changed the title
mjsabby
force-pushed
the
profilerGetObjectReferences
branch
from
09a37fe
to
702e568
Compare
noahfalk
reviewed
Apr 23, 2019
mjsabby
force-pushed
the
profilerGetObjectReferences
branch
2 times, most recently
from
c712a50
to
1b50761
Compare
mjsabby
force-pushed
the
profilerGetObjectReferences
branch
from
1b50761
to
77d39a3
Compare
|
LGTM for the new changes |
|
Can someone check this in please? |
|
I'm happy to merge this but I wanted to make sure that diagnostics folks are ok with the API stuff here. @noahfalk do you need more time to think about this? I think it's ok to have it as 2 flags - light and medium, and they are exclusive (ie, medium does not imply light). if they are ok with this then we'll merge. |
noahfalk
approved these changes
Apr 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/dotnet/coreclr/issues/24155 & https://github.com/dotnet/coreclr/issues/24132.