Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUse native code slot for default interface methods #25770
Merged
Conversation
|
LGTM, sorry it took me a while to get to this one |
This comment has been minimized.
This comment has been minimized.
|
Thank you! |
- So that `MethodDesc::GetNativeCode()` can retrieve the current native code entry point (instead of returning null as before), and code versioning can find a matching code version from the code start address - Interface methods currently require having a precode, so the "method entry point" can't be used to directly store the native code entry point - Reenabled a couple of default interface method tests under GCStress - Other small cleanup Fixes https://github.com/dotnet/coreclr/issues/25690
This comment has been minimized.
This comment has been minimized.
|
@kouvel Can this be merged? There's 3 more issues that are likely the same root cause (it's GCStress crashes in default interface tests, even though we haven't touched default interfaces in many months). |
This comment has been minimized.
This comment has been minimized.
|
Thanks for rerunning the CI, I'll go ahead and merge |
kouvel
merged commit 98bf56a
into
dotnet:master
38 checks passed
38 checks passed
coreclr-ci (Test Pri0 CoreFX Linux x64 checked)
Test Pri0 CoreFX Linux x64 checked succeeded
Details
coreclr-ci (Test Pri0 CoreFX Windows_NT x64 checked)
Test Pri0 CoreFX Windows_NT x64 checked succeeded
Details
coreclr-ci (Test Pri0 R2R Windows_NT x64 checked)
Test Pri0 R2R Windows_NT x64 checked succeeded
Details
coreclr-ci (Test Pri0 R2R Windows_NT x86 checked)
Test Pri0 R2R Windows_NT x86 checked succeeded
Details
coreclr-ci (Test Pri0 Windows_NT arm64 checked)
Test Pri0 Windows_NT arm64 checked succeeded
Details
coreclr-ci (Test crossgen-comparison Linux arm checked)
Test crossgen-comparison Linux arm checked succeeded
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kouvel commentedJul 18, 2019
MethodDesc::GetNativeCode()can retrieve the current native code entry point (instead of returning null as before), and code versioning can find a matching code version from the code start addressFixes https://github.com/dotnet/coreclr/issues/25690