New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building of GCSample on x86 via the standalone VS project #2582

Merged
merged 1 commit into from Jan 9, 2016

Conversation

Projects
None yet
4 participants
@jkotas
Member

jkotas commented Jan 8, 2016

The standalone VS projects defaults to x86 - trying to use it to build surfaced a few x86-specific build breaks. Thanks to @mattwarren for reporting it (#1548).

@jkotas

This comment has been minimized.

Show comment
Hide comment
Member

jkotas commented Jan 8, 2016

@janvorli PTLA

@janvorli

This comment has been minimized.

Show comment
Hide comment
@janvorli

janvorli Jan 8, 2016

Member

LGTM

Member

janvorli commented Jan 8, 2016

LGTM

jkotas added a commit that referenced this pull request Jan 9, 2016

Merge pull request #2582 from jkotas/fix-gcsample-x86
Fix building of GCSample on x86 via the standalone VS project

@jkotas jkotas merged commit 3c15c20 into dotnet:master Jan 9, 2016

7 of 10 checks passed

Windows_NT x86 Debug Build Build finished. No test results found.
Details
Windows_NT x86 Release Build Build finished. No test results found.
Details
OSX x64 Release Build and Test Build started sha1 is merged.
Details
CentOS7.1 x64 Debug Build Build finished. 803 tests run, 0 skipped, 0 failed.
Details
CentOS7.1 x64 Release Build Build finished. 803 tests run, 0 skipped, 0 failed.
Details
FreeBSD x64 Debug Build Build finished. 803 tests run, 0 skipped, 0 failed.
Details
FreeBSD x64 Release Build Build finished. 803 tests run, 0 skipped, 0 failed.
Details
Ubuntu x64 Release Build and Test Build finished. No test results found.
Details
Windows_NT x64 Debug Build and Test Build finished. No test results found.
Details
Windows_NT x64 Release Build and Test Build finished. No test results found.
Details

@jkotas jkotas deleted the jkotas:fix-gcsample-x86 branch Jan 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment