Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that we check for implicit ivals for single argument intrinsics before the SIMDScalar handling. #25987

Merged
merged 1 commit into from Aug 7, 2019

Conversation

@tannergooding
Copy link
Member

commented Aug 2, 2019

Description

Certain intrinsic functions which took one argument, had an implicit immediate value , and were marked as SIMDScalar were not being handled correctly in codegen.

Customer Impact

Customers using functions qualifying under the above conditions would get invalid results in their program.

Regression?

Yes, as per the description.

Risk

Low. This just reorders the branch statements and the list of intrinsics that are impacted is small and well-defined: there are 102 intrinsics marked SIMDScalar and only 7 of them have both an implicit immediate value and take one argument.

Ensure that we check for implicit ivals for single argument intrinsic…
…s before the SIMDScalar handling. (#25905)

* Ensure that we check for implicit ivals for single argument intrinsics before the SIMDScalar handling.

* Adding test template entries for the unary overloads of the Sse41.Round functions

* Regenerating the hardware intrinsic test templates.

@tannergooding tannergooding added this to the 3.0 milestone Aug 2, 2019

@tannergooding

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

CC. @CarolEidt, @AndyAyersMS

This is the backport of #25905 to release/3.0. This needs @MeiChin-Tsai's approval as well, correct?

@AndyAyersMS

This comment has been minimized.

Copy link
Member

commented Aug 2, 2019

This needs @MeiChin-Tsai's approval as well, correct?

At a minimum -- there may be more process now.

@danmosemsft

This comment has been minimized.

Copy link
Member

commented Aug 2, 2019

At a minimum -- there may be more process now.

It needs to get ok from Tactics on Tues.

@danmosemsft

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

Approved by tactics for 3.0, @wtgodbe or @Anipik will merge when branch opens for preview 9.

@danmosemsft

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

(assuming CI is green)

@danmosemsft danmosemsft removed the ask-mode label Aug 6, 2019

@wtgodbe

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

Branch is open, merging

@wtgodbe wtgodbe merged commit b4a56b0 into dotnet:release/3.0 Aug 7, 2019

37 checks passed

WIP Ready for review
Details
coreclr-ci Build #20190802.8 had test failures
Details
coreclr-ci (Build Linux arm checked) Build Linux arm checked succeeded
Details
coreclr-ci (Build Linux arm64 checked) Build Linux arm64 checked succeeded
Details
coreclr-ci (Build Linux arm64 release) Build Linux arm64 release succeeded
Details
coreclr-ci (Build Linux_musl x64 checked) Build Linux_musl x64 checked succeeded
Details
coreclr-ci (Build Linux_musl x64 release) Build Linux_musl x64 release succeeded
Details
coreclr-ci (Build Linux_rhel6 x64 release) Build Linux_rhel6 x64 release succeeded
Details
coreclr-ci (Build Windows_NT arm Checked) Build Windows_NT arm Checked succeeded
Details
coreclr-ci (Build Windows_NT arm64 Checked) Build Windows_NT arm64 Checked succeeded
Details
coreclr-ci (Build Windows_NT x64 Checked) Build Windows_NT x64 Checked succeeded
Details
coreclr-ci (Build Windows_NT x64 Debug) Build Windows_NT x64 Debug succeeded
Details
coreclr-ci (Build Windows_NT x86 Checked) Build Windows_NT x86 Checked succeeded
Details
coreclr-ci (Build Windows_NT x86 Debug) Build Windows_NT x86 Debug succeeded
Details
coreclr-ci (Formatting Linux x64) Formatting Linux x64 succeeded
Details
coreclr-ci (Test Pri0 CoreFX Linux x64 checked) Test Pri0 CoreFX Linux x64 checked succeeded
Details
coreclr-ci (Test Pri0 CoreFX Windows_NT x64 checked) Test Pri0 CoreFX Windows_NT x64 checked succeeded
Details
coreclr-ci (Test Pri0 Linux x64 checked) Test Pri0 Linux x64 checked succeeded
Details
coreclr-ci (Test Pri0 Linux_musl x64 release) Test Pri0 Linux_musl x64 release succeeded
Details
coreclr-ci (Test Pri0 OSX x64 checked) Test Pri0 OSX x64 checked succeeded
Details
coreclr-ci (Test Pri0 R2R Linux x64 checked) Test Pri0 R2R Linux x64 checked succeeded
Details
coreclr-ci (Test Pri0 R2R OSX x64 checked) Test Pri0 R2R OSX x64 checked succeeded
Details
coreclr-ci (Test Pri0 R2R Windows_NT x64 checked) Test Pri0 R2R Windows_NT x64 checked succeeded
Details
coreclr-ci (Test Pri0 R2R Windows_NT x86 checked) Test Pri0 R2R Windows_NT x86 checked succeeded
Details
coreclr-ci (Test Pri0 Windows_NT arm checked) Test Pri0 Windows_NT arm checked succeeded
Details
coreclr-ci (Test Pri0 Windows_NT arm64 checked) Test Pri0 Windows_NT arm64 checked succeeded
Details
coreclr-ci (Test Pri0 Windows_NT x64 checked) Test Pri0 Windows_NT x64 checked succeeded
Details
coreclr-ci (Test Pri0 Windows_NT x86 checked) Test Pri0 Windows_NT x86 checked succeeded
Details
coreclr-ci (Test pri0 Linux arm checked) Test pri0 Linux arm checked succeeded
Details
coreclr-ci (Test pri0 Linux arm64 checked) Test pri0 Linux arm64 checked succeeded
Details
coreclr-ci (Test pri0 Linux_musl x64 checked) Test pri0 Linux_musl x64 checked succeeded
Details
coreclr-ci (build Linux x64 Checked) build Linux x64 Checked succeeded
Details
coreclr-ci (build OSX x64 Checked) build OSX x64 Checked succeeded
Details
coreclr-ci (build Windows_NT arm Release) build Windows_NT arm Release succeeded
Details
coreclr-ci (build Windows_NT arm64 Release) build Windows_NT arm64 Release succeeded
Details
coreclr-ci (build Windows_NT x64 Release) build Windows_NT x64 Release succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.