Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/3.1] Address regression in TimeSpan precision (#26992) #27010

Merged
merged 1 commit into from Oct 4, 2019

Conversation

@jkotas
Copy link
Member

commented Oct 3, 2019

Change multiplying by (x * (1.0 / BigValue)) on (x / BigValue).

Fix #41380


Description

.NET Core 3.0 change that was supposed to improve precision of TimeSpan conversions regressed the precision in some cases due to floating point rounding errors.

Customer Impact

TimeSpan conversions return incorrect results in some cases.

Regression?
Yes. .NET Core 2.x -> 3.0.

Risk
Low. Straightforward change.

Change multiplying by (x * (1.0 / BigValue)) on (x / BigValue).

Fix #41380
@jkotas jkotas changed the title Improve TimeSpan precision (#26992) [release/3.1] Improve TimeSpan precision (#26992) Oct 3, 2019
@jkotas

This comment has been minimized.

Copy link
Member Author

commented Oct 3, 2019

@danmosemsft

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

OK, approved, please merge when ready.

@danmosemsft danmosemsft changed the title [release/3.1] Improve TimeSpan precision (#26992) [release/3.1] Address regression in TimeSpan precision (#26992) Oct 3, 2019
@jkotas jkotas merged commit 5fcd92c into dotnet:release/3.1 Oct 4, 2019
35 of 37 checks passed
35 of 37 checks passed
coreclr-ci Build #20191003.18 had test failures
Details
coreclr-ci (Test Pri0 R2R Windows_NT x64 checked) Test Pri0 R2R Windows_NT x64 checked failed
Details
WIP Ready for review
Details
coreclr-ci (Formatting Linux x64) Formatting Linux x64 succeeded
Details
coreclr-ci (Linux arm checked) Linux arm checked succeeded
Details
coreclr-ci (Linux arm64 checked) Linux arm64 checked succeeded
Details
coreclr-ci (Linux arm64 release) Linux arm64 release succeeded
Details
coreclr-ci (Linux x64 checked) Linux x64 checked succeeded
Details
coreclr-ci (Linux_musl x64 checked) Linux_musl x64 checked succeeded
Details
coreclr-ci (Linux_musl x64 release) Linux_musl x64 release succeeded
Details
coreclr-ci (Linux_rhel6 x64 release) Linux_rhel6 x64 release succeeded
Details
coreclr-ci (OSX x64 checked) OSX x64 checked succeeded
Details
coreclr-ci (Test Pri0 CoreFX Linux x64 checked) Test Pri0 CoreFX Linux x64 checked succeeded
Details
coreclr-ci (Test Pri0 CoreFX Windows_NT x64 checked) Test Pri0 CoreFX Windows_NT x64 checked succeeded
Details
coreclr-ci (Test Pri0 Linux arm checked) Test Pri0 Linux arm checked succeeded
Details
coreclr-ci (Test Pri0 Linux arm64 checked) Test Pri0 Linux arm64 checked succeeded
Details
coreclr-ci (Test Pri0 Linux x64 checked) Test Pri0 Linux x64 checked succeeded
Details
coreclr-ci (Test Pri0 Linux_musl x64 checked) Test Pri0 Linux_musl x64 checked succeeded
Details
coreclr-ci (Test Pri0 Linux_musl x64 release) Test Pri0 Linux_musl x64 release succeeded
Details
coreclr-ci (Test Pri0 OSX x64 checked) Test Pri0 OSX x64 checked succeeded
Details
coreclr-ci (Test Pri0 R2R Linux x64 checked) Test Pri0 R2R Linux x64 checked succeeded
Details
coreclr-ci (Test Pri0 R2R OSX x64 checked) Test Pri0 R2R OSX x64 checked succeeded
Details
coreclr-ci (Test Pri0 R2R Windows_NT x86 checked) Test Pri0 R2R Windows_NT x86 checked succeeded
Details
coreclr-ci (Test Pri0 Windows_NT arm checked) Test Pri0 Windows_NT arm checked succeeded
Details
coreclr-ci (Test Pri0 Windows_NT arm64 checked) Test Pri0 Windows_NT arm64 checked succeeded
Details
coreclr-ci (Test Pri0 Windows_NT x64 checked) Test Pri0 Windows_NT x64 checked succeeded
Details
coreclr-ci (Test Pri0 Windows_NT x86 checked) Test Pri0 Windows_NT x86 checked succeeded
Details
coreclr-ci (Windows_NT arm checked) Windows_NT arm checked succeeded
Details
coreclr-ci (Windows_NT arm release) Windows_NT arm release succeeded
Details
coreclr-ci (Windows_NT arm64 checked) Windows_NT arm64 checked succeeded
Details
coreclr-ci (Windows_NT arm64 release) Windows_NT arm64 release succeeded
Details
coreclr-ci (Windows_NT x64 checked) Windows_NT x64 checked succeeded
Details
coreclr-ci (Windows_NT x64 debug) Windows_NT x64 debug succeeded
Details
coreclr-ci (Windows_NT x64 release) Windows_NT x64 release succeeded
Details
coreclr-ci (Windows_NT x86 checked) Windows_NT x86 checked succeeded
Details
coreclr-ci (Windows_NT x86 debug) Windows_NT x86 debug succeeded
Details
license/cla All CLA requirements met.
Details
@jkotas jkotas deleted the jkotas:fix-41380 branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.