Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert CPU clipping in the presence of CPU quota to 3.0, 2.x behavior. #27990

Merged
merged 1 commit into from Jan 15, 2020

Conversation

@VSadov
Copy link
Member

VSadov commented Jan 14, 2020

This is a fix for an issue tracked by dotnet/runtime#622.
It is a reversal of a change made in 3.1 vs. 3.0 and 2.X
(Basically reverting #26806)
The change was an improvement in some cases, but was causing considerable performance regressions in constrained container scenarios.

Customer Impact

Customers report performance regressions in constrained container scenarios when CPU quotas are applied.

Regression?

Yes. From 3.0 and 2.x

Testing

Regular PR tests.
Verified that the most affected aspnet benchmarks are back to 3.0 performance levels.

Risk

Low: This is reverting to behavior that we had for a few releases.

@jkotas
jkotas approved these changes Jan 14, 2020
@jkotas

This comment has been minimized.

Copy link
Member

jkotas commented Jan 14, 2020

We should make the same change in dotnet/runtime master as well.

@jkotas

This comment has been minimized.

Copy link
Member

jkotas commented Jan 14, 2020

Could you please update the PR description to match the servicing template, and then send it for approval?

@VSadov

This comment has been minimized.

Copy link
Member Author

VSadov commented Jan 14, 2020

Updated description.

@VSadov VSadov changed the title clip CPU count when CPU cycle quota is applied. Revert CPU clipping in the presence of CPU quota to 3.0, 2.x behavior. Jan 14, 2020
@jeffschwMSFT jeffschwMSFT added this to the 3.1.x milestone Jan 14, 2020
@VSadov

This comment has been minimized.

Copy link
Member Author

VSadov commented Jan 14, 2020

CC: @MeiChin-Tsai - for approval.

@jeffschwMSFT jeffschwMSFT modified the milestones: 3.1.x, 3.1.2 Jan 15, 2020
@jeffschwMSFT

This comment has been minimized.

Copy link
Member

jeffschwMSFT commented Jan 15, 2020

Approved by Steve (via email)

@VSadov

This comment has been minimized.

Copy link
Member Author

VSadov commented Jan 15, 2020

CC:@kouvel

@VSadov VSadov merged commit c43d033 into dotnet:release/3.1 Jan 15, 2020
36 checks passed
36 checks passed
WIP Ready for review
Details
coreclr-ci Build #20200113.1 had test failures
Details
coreclr-ci (Linux arm checked) Linux arm checked succeeded
Details
coreclr-ci (Linux arm64 checked) Linux arm64 checked succeeded
Details
coreclr-ci (Linux arm64 release) Linux arm64 release succeeded
Details
coreclr-ci (Linux x64 checked) Linux x64 checked succeeded
Details
coreclr-ci (Linux_musl x64 checked) Linux_musl x64 checked succeeded
Details
coreclr-ci (Linux_musl x64 release) Linux_musl x64 release succeeded
Details
coreclr-ci (Linux_rhel6 x64 release) Linux_rhel6 x64 release succeeded
Details
coreclr-ci (OSX x64 checked) OSX x64 checked succeeded
Details
coreclr-ci (Test Pri0 CoreFX Linux x64 checked) Test Pri0 CoreFX Linux x64 checked succeeded
Details
coreclr-ci (Test Pri0 CoreFX Windows_NT x64 checked) Test Pri0 CoreFX Windows_NT x64 checked succeeded
Details
coreclr-ci (Test Pri0 Linux arm checked) Test Pri0 Linux arm checked succeeded
Details
coreclr-ci (Test Pri0 Linux arm64 checked) Test Pri0 Linux arm64 checked succeeded
Details
coreclr-ci (Test Pri0 Linux x64 checked) Test Pri0 Linux x64 checked succeeded
Details
coreclr-ci (Test Pri0 Linux_musl x64 checked) Test Pri0 Linux_musl x64 checked succeeded
Details
coreclr-ci (Test Pri0 Linux_musl x64 release) Test Pri0 Linux_musl x64 release succeeded
Details
coreclr-ci (Test Pri0 OSX x64 checked) Test Pri0 OSX x64 checked succeeded
Details
coreclr-ci (Test Pri0 R2R Linux x64 checked) Test Pri0 R2R Linux x64 checked succeeded
Details
coreclr-ci (Test Pri0 R2R OSX x64 checked) Test Pri0 R2R OSX x64 checked succeeded
Details
coreclr-ci (Test Pri0 R2R Windows_NT x64 checked) Test Pri0 R2R Windows_NT x64 checked succeeded
Details
coreclr-ci (Test Pri0 R2R Windows_NT x86 checked) Test Pri0 R2R Windows_NT x86 checked succeeded
Details
coreclr-ci (Test Pri0 Windows_NT arm checked) Test Pri0 Windows_NT arm checked succeeded
Details
coreclr-ci (Test Pri0 Windows_NT arm64 checked) Test Pri0 Windows_NT arm64 checked succeeded
Details
coreclr-ci (Test Pri0 Windows_NT x64 checked) Test Pri0 Windows_NT x64 checked succeeded
Details
coreclr-ci (Test Pri0 Windows_NT x86 checked) Test Pri0 Windows_NT x86 checked succeeded
Details
coreclr-ci (Windows_NT arm checked) Windows_NT arm checked succeeded
Details
coreclr-ci (Windows_NT arm release) Windows_NT arm release succeeded
Details
coreclr-ci (Windows_NT arm64 checked) Windows_NT arm64 checked succeeded
Details
coreclr-ci (Windows_NT arm64 release) Windows_NT arm64 release succeeded
Details
coreclr-ci (Windows_NT x64 checked) Windows_NT x64 checked succeeded
Details
coreclr-ci (Windows_NT x64 debug) Windows_NT x64 debug succeeded
Details
coreclr-ci (Windows_NT x64 release) Windows_NT x64 release succeeded
Details
coreclr-ci (Windows_NT x86 checked) Windows_NT x86 checked succeeded
Details
coreclr-ci (Windows_NT x86 debug) Windows_NT x86 debug succeeded
Details
license/cla All CLA requirements met.
Details
@VSadov VSadov deleted the VSadov:clip branch Jan 15, 2020
@VSadov

This comment has been minimized.

Copy link
Member Author

VSadov commented Jan 15, 2020

Thanks!!!

@MeiChin-Tsai

This comment has been minimized.

Copy link

MeiChin-Tsai commented Jan 15, 2020

Thanks, Vlad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.