Fix conversion from CorJitFlag2 enum to JitFlag. #7857

Merged
merged 1 commit into from Oct 28, 2016

Conversation

Projects
None yet
5 participants
@AustinWise
Contributor

AustinWise commented Oct 27, 2016

It looks like #7837 had a copy and paste error in the JitFlags class it introduced. The method SetFromOldFlags defines the macros CONVERT_OLD_FLAG and CONVERT_OLD_FLAG2 identically and ignores the corJitFlags2 parameter.
This commit changes CONVERT_OLD_FLAG2 to compare flags against the corJitFlags2 parameter.

@BruceForstall

This comment has been minimized.

Show comment
Hide comment
@BruceForstall

BruceForstall Oct 27, 2016

Contributor

LGTM. Thanks!

Contributor

BruceForstall commented Oct 27, 2016

LGTM. Thanks!

@jkotas jkotas merged commit e1faf24 into dotnet:master Oct 28, 2016

14 checks passed

CentOS7.1 x64 Debug Build and Test Build finished.
Details
FreeBSD x64 Checked Build Build finished.
Details
Linux ARM Emulator Cross Debug Build Build finished.
Details
Linux ARM Emulator Cross Release Build Build finished.
Details
OSX x64 Checked Build and Test Build finished.
Details
Ubuntu x64 Checked Build and Test Build finished.
Details
Ubuntu x64 Formatting Build finished.
Details
Windows_NT arm Cross Debug Build Build finished.
Details
Windows_NT arm Cross Release Build Build finished.
Details
Windows_NT x64 Debug Build and Test Build finished.
Details
Windows_NT x64 Formatting Build finished.
Details
Windows_NT x64 Release Priority 1 Build and Test Build finished.
Details
Windows_NT x86 legacy_backend Checked Build and Test Build finished.
Details
Windows_NT x86 ryujit Checked Build and Test Build finished.
Details

@AustinWise AustinWise deleted the AustinWise:fixFlagConversion branch Oct 28, 2016

@karelz karelz modified the milestone: 2.0.0 Aug 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment