Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upComplete FreeBSD bringup #827
Conversation
dnfclas
added
the
cla-already-signed
label
Apr 26, 2015
richlander
added
the
os-freebsd
label
Apr 26, 2015
This comment has been minimized.
This comment has been minimized.
|
LGTM. Beautiful! Thanks a lot. |
This comment has been minimized.
This comment has been minimized.
|
@dotnet-bot test this please |
This comment has been minimized.
This comment has been minimized.
|
Looks like the linux debug jenkins box was unhappy for unrelated reasons: http://dotnet-ci.cloudapp.net/job/dotnet_coreclr_linux_debug_prtest/1017/console |
This comment has been minimized.
This comment has been minimized.
|
Awesome! |
added a commit
that referenced
this pull request
Apr 26, 2015
jkotas
merged commit 1c2d91b
into
dotnet:master
Apr 26, 2015
1 check passed
default
Merged build finished.
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kangaroo commentedApr 26, 2015
Fixes issue #801 which was caused by the CoreCLR and PAL being
dlopened, but pthread not being initialized by the runtime linker yet.
FreeBSD requires that the main executable load pthread, rather than a
downstream dependency. Also fixed a few missing calls to pthread_attr_init
which was causing asserts() on FBSD.