Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete FreeBSD bringup #827

Merged
merged 1 commit into from Apr 26, 2015
Merged

Complete FreeBSD bringup #827

merged 1 commit into from Apr 26, 2015

Conversation

@kangaroo
Copy link

@kangaroo kangaroo commented Apr 26, 2015

Fixes issue #801 which was caused by the CoreCLR and PAL being
dlopened, but pthread not being initialized by the runtime linker yet.
FreeBSD requires that the main executable load pthread, rather than a
downstream dependency. Also fixed a few missing calls to pthread_attr_init
which was causing asserts() on FBSD.

Fixes issue #801 which was caused by the CoreCLR and PAL being
dlopened, but pthread not being initialized by the runtime linker yet.
FreeBSD requires that the main executable load pthread, rather than a
downstream dependency.  Also fixed a few missing calls to pthread_attr_init
which was causing asserts() on FBSD.
@janvorli
Copy link
Member

@janvorli janvorli commented Apr 26, 2015

LGTM. Beautiful! Thanks a lot.

@kangaroo
Copy link
Author

@kangaroo kangaroo commented Apr 26, 2015

@dotnet-bot test this please

@kangaroo
Copy link
Author

@kangaroo kangaroo commented Apr 26, 2015

Looks like the linux debug jenkins box was unhappy for unrelated reasons:

http://dotnet-ci.cloudapp.net/job/dotnet_coreclr_linux_debug_prtest/1017/console

@jkotas
Copy link
Member

@jkotas jkotas commented Apr 26, 2015

Awesome!

jkotas added a commit that referenced this pull request Apr 26, 2015
@jkotas jkotas merged commit 1c2d91b into dotnet:master Apr 26, 2015
1 check passed
1 check passed
default Merged build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants