This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fix an error in build-test.cmd #8890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parjong
force-pushed
the
fix/probe_win
branch
from
c991df4
to
78be1c0
Compare
|
@dotnet-bot test this please |
|
@parjong I am not experiencing this problem. My CMake is in |
|
@janvorli You're right. I found this issue while working on some Jenkns instance (I have no direct access). I guessed that this issue comes from CMake, but it turns out that the project path itself causes this issue. |
This reverts commit 78be1c0.
|
@janvorli Could you let me know who is responsible to this issue? It seems like overkill to mention dotnet/coreclr-contrib. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Fix an error in CMake Probe * Add double qutation around %__ProjectDir * Revert "Fix an error in CMake Probe" This reverts commit dotnet/coreclr@78be1c0. Commit migrated from dotnet/coreclr@e7369c5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build-test.cmdfailed to execute internal scripts when the current project directory path includes spaces.This commit adds double quotation to prevent this issue.