This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
[x86/Linux] Fix RtlRestoreContext #8916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
\CC @seanshpark |
janvorli
reviewed
Jan 12, 2017
| push ecx | ||
| mov ecx, [eax + CONTEXT_Eax] | ||
| push ecx | ||
| push DWORD PTR [eax + CONTEXT_Edi] |
There was a problem hiding this comment.
Can't we just load the registers from the context (doing the eax read as the last one) instead of pushing all of them and the popping?
|
@janvorli Could you merge this PR if there is no further issue? |
|
@parjong I am sorry for the delay. I just wish github had a button "merge after successful CI". |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* [x86/Linux] Fix RtlRestoreContext * Use mov instead of push/pop Commit migrated from dotnet/coreclr@a6dccc8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
RtlRestoreContextfor x86/Linux is incorrect. which results in segfault discussed in #8887.This commit re-implements
RtlRestoreContextto resolve #8887.