Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

[x86/Linux] Enable FEATURE_ARRAYSTUB_AS_IL#9752

Merged
jkotas merged 2 commits intodotnet:masterfrom
parjong:fix/x86_ARRAYSTUB_AS_IL
Feb 24, 2017
Merged

[x86/Linux] Enable FEATURE_ARRAYSTUB_AS_IL#9752
jkotas merged 2 commits intodotnet:masterfrom
parjong:fix/x86_ARRAYSTUB_AS_IL

Conversation

@parjong
Copy link

@parjong parjong commented Feb 23, 2017

This commit enables FEATURE_ARRAYSTUB_AS_IL for x86/Linux to fix #9687.

@parjong
Copy link
Author

parjong commented Feb 23, 2017

This PR addresses the incorrect unwind issue discussed in #9688.

</PropertyGroup>

<PropertyGroup Condition="'$(TargetsUnix)' != 'true'">
<FeatureArrayStubAsIL Condition="('$(TargetArch)' == 'arm') or ('$(TargetArch)' == 'amd64') or ('$(TargetArch)' == 'arm64')">true</FeatureArrayStubAsIL>
Copy link
Member

@jkotas jkotas Feb 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I would be nice to move FeatureStubsAsIL from the common block to here as well.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkotas Thanks you for comment! It would be much better. 7ec9019 revised PR as you suggested.

@parjong
Copy link
Author

parjong commented Feb 24, 2017

@dotnet-bot test Windows_NT x64 Release Priority 1 Build and Test please

@jkotas jkotas merged commit 70b21c8 into dotnet:master Feb 24, 2017
@parjong parjong deleted the fix/x86_ARRAYSTUB_AS_IL branch February 24, 2017 06:10
jorive pushed a commit to guhuro/coreclr that referenced this pull request May 4, 2017
* [x86/Linux] Enable FEATURE_ARRAYSTUB_AS_IL
* Move FeatureStubsAsIL into Windows-specific block
@karelz karelz modified the milestone: 2.0.0 Aug 28, 2017
@xiangzhai
Copy link

:mips-interest

picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
* [x86/Linux] Enable FEATURE_ARRAYSTUB_AS_IL
* Move FeatureStubsAsIL into Windows-specific block

Commit migrated from dotnet/coreclr@70b21c8
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[x86/Linux] PAL_SEHException is thrown while running b119538 tests

5 participants