Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[x86/Linux] Enable FEATURE_ARRAYSTUB_AS_IL #9752

Merged
merged 2 commits into from Feb 24, 2017

Conversation

@parjong
Copy link
Contributor

commented Feb 23, 2017

This commit enables FEATURE_ARRAYSTUB_AS_IL for x86/Linux to fix #9687.

@parjong

This comment has been minimized.

Copy link
Contributor Author

commented Feb 23, 2017

This PR addresses the incorrect unwind issue discussed in #9688.

@@ -83,6 +83,7 @@
</PropertyGroup>

<PropertyGroup Condition="'$(TargetsUnix)' != 'true'">
<FeatureArrayStubAsIL Condition="('$(TargetArch)' == 'arm') or ('$(TargetArch)' == 'amd64') or ('$(TargetArch)' == 'arm64')">true</FeatureArrayStubAsIL>

This comment has been minimized.

Copy link
@jkotas

jkotas Feb 23, 2017

Member

Nit: I would be nice to move FeatureStubsAsIL from the common block to here as well.

This comment has been minimized.

Copy link
@parjong

parjong Feb 23, 2017

Author Contributor

@jkotas Thanks you for comment! It would be much better. 7ec9019 revised PR as you suggested.

@jkotas
jkotas approved these changes Feb 23, 2017
@parjong

This comment has been minimized.

Copy link
Contributor Author

commented Feb 24, 2017

@dotnet-bot test Windows_NT x64 Release Priority 1 Build and Test please

@jkotas jkotas merged commit 70b21c8 into dotnet:master Feb 24, 2017
13 checks passed
13 checks passed
CentOS7.1 x64 Debug Build and Test Build finished.
Details
FreeBSD x64 Checked Build Build finished.
Details
Linux ARM Emulator Cross Debug Build Build finished.
Details
Linux ARM Emulator Cross Release Build Build finished.
Details
OSX x64 Checked Build and Test Build finished.
Details
Ubuntu x64 Checked Build and Test Build finished.
Details
Ubuntu x64 Formatting Build finished.
Details
Windows_NT arm Cross Debug Build Build finished.
Details
Windows_NT arm Cross Release Build Build finished.
Details
Windows_NT x64 Debug Build and Test Build finished.
Details
Windows_NT x64 Formatting Build finished.
Details
Windows_NT x64 Release Priority 1 Build and Test Build finished.
Details
Windows_NT x86 Checked Build and Test Build finished.
Details
@parjong parjong deleted the parjong:fix/x86_ARRAYSTUB_AS_IL branch Feb 24, 2017
jorive added a commit to guhuro/coreclr that referenced this pull request May 4, 2017
* [x86/Linux] Enable FEATURE_ARRAYSTUB_AS_IL
* Move FeatureStubsAsIL into Windows-specific block
@karelz karelz modified the milestone: 2.0.0 Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.