diff --git a/Directory.Build.props b/Directory.Build.props index 44dac8136f11..cc9593f39db0 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -50,19 +50,14 @@ - - $(RepoRoot) $(ProjectDir)artifacts\bin\ - $(ProjectDir)src\ - - - $(ProjectDir)artifacts/tools/ - $(BinDir)tests/ + + $([MSBuild]::NormalizeDirectory('$(ProjectDir)', 'src')) $(DotNetRestorePackagesPath) @@ -111,7 +106,7 @@ - true + true @@ -122,7 +117,7 @@ - false + false false @@ -264,21 +259,8 @@ true - - - <_IsTestProjectBefore>$(IsTestProject) - <_IsPerformanceTestProjectBefore>$(IsPerformanceTestProject) - - - - - - $(_IsTestProjectBefore) - $(_IsPerformanceTestProjectBefore) - - @@ -363,6 +345,7 @@ $(BinDir)runtime/$(BuildConfiguration)/ $(BinDir)shimsTargetRuntime/ + $(ArtifactsBinDir)tests/ $(TestWorkingDir)$(MSBuildProjectName)/$(BuildConfiguration)/ $(BinDir)ref/ $(RefRootPath)$(_bc_TargetGroup)/ @@ -372,8 +355,9 @@ $(RefRootPath)netstandard/ $(RefRootPath)netfx/ $(ProjectDir)artifacts/helix/ - $(TestArchiveRoot)tests/ + $(TestArchiveRoot)tests/$(BuildConfiguration)/ $(TestArchiveRoot)runtime/$(BuildConfiguration)/ + $(ArtifactsDir)tools/ $(ProjectDir)\external\runtime\runtime.depproj diff --git a/Directory.Build.targets b/Directory.Build.targets index c9c4fd9aa230..217b610cf39e 100644 --- a/Directory.Build.targets +++ b/Directory.Build.targets @@ -149,8 +149,6 @@ - - diff --git a/Documentation/building/code-coverage.md b/Documentation/building/code-coverage.md index 1e780edcbc02..d5ebbe2e0da7 100644 --- a/Documentation/building/code-coverage.md +++ b/Documentation/building/code-coverage.md @@ -22,7 +22,7 @@ Our default, somewhat-arbitrary initial goal for a library is 90% code coverage. Issues are opened for a library when a cursory examination of its code coverage reveal that there are likely still some meaningful gaps that need to be addressed. We welcome contributions to our test suites to help address these gaps and close these issues. Many of these issues are marked as [up-for-grabs](https://github.com/dotnet/corefx/labels/up-for-grabs). -An issue need not be addressed in its entirety. We happily accept contributions that improve our tests and work towards improving code coverage numbers even if they only incrementally improve the situation. +An issue need not be addressed in its entirety. We happily accept contributions that improve our tests and work towards improving code coverage numbers even if they only incrementally improve the situation. ## Automated Code Coverage Runs diff --git a/eng/Tools.props b/eng/Tools.props index 1cd35cd089e4..2f14b2784e1a 100644 --- a/eng/Tools.props +++ b/eng/Tools.props @@ -27,6 +27,7 @@ + diff --git a/eng/Versions.props b/eng/Versions.props index 75fe48eeba9f..d621507ab99f 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -21,5 +21,6 @@ 1.0.0-beta.18578.2 2.4.0-beta.18578.2 1.0.0-beta.18578.2 + 1.0.0-beta.18603.8 diff --git a/eng/dependencies.props b/eng/dependencies.props index 7946cc4d271f..3eb74e1655f1 100644 --- a/eng/dependencies.props +++ b/eng/dependencies.props @@ -47,7 +47,7 @@ 4.4.0 - 15.8.0 + 16.0.0-preview-20181128-01 2.4.1-pre.build.4059 1.0.0-beta-build0020 2.0.5 diff --git a/src/Directory.Build.props b/src/Directory.Build.props index e82d0d460ead..b3269a936bc9 100644 --- a/src/Directory.Build.props +++ b/src/Directory.Build.props @@ -19,9 +19,10 @@ $(AssemblySearchPaths);$(RefPath);{RawFileName} + - - + + @@ -29,4 +30,10 @@ + + + + fullPath="".*System\.Private\.CoreLib\\shared + fullPath=""""$(CommonPath)\CoreLib + diff --git a/src/System.Collections.Immutable/tests/System.Collections.Immutable.Tests.csproj b/src/System.Collections.Immutable/tests/System.Collections.Immutable.Tests.csproj index ac4609130c31..679018491c98 100644 --- a/src/System.Collections.Immutable/tests/System.Collections.Immutable.Tests.csproj +++ b/src/System.Collections.Immutable/tests/System.Collections.Immutable.Tests.csproj @@ -98,7 +98,7 @@ - + diff --git a/src/System.ComponentModel.Composition.Registration/tests/System.ComponentModel.Composition.Registration.Tests.csproj b/src/System.ComponentModel.Composition.Registration/tests/System.ComponentModel.Composition.Registration.Tests.csproj index 99f62f78e27f..7907b51afa68 100644 --- a/src/System.ComponentModel.Composition.Registration/tests/System.ComponentModel.Composition.Registration.Tests.csproj +++ b/src/System.ComponentModel.Composition.Registration/tests/System.ComponentModel.Composition.Registration.Tests.csproj @@ -6,7 +6,7 @@ - + diff --git a/src/System.ComponentModel.Composition/tests/System.ComponentModel.Composition.Tests.csproj b/src/System.ComponentModel.Composition/tests/System.ComponentModel.Composition.Tests.csproj index bbe773682cde..e9678bf6638a 100644 --- a/src/System.ComponentModel.Composition/tests/System.ComponentModel.Composition.Tests.csproj +++ b/src/System.ComponentModel.Composition/tests/System.ComponentModel.Composition.Tests.csproj @@ -6,7 +6,7 @@ - + diff --git a/src/System.ComponentModel.TypeConverter/tests/AddingNewEventArgsTests.cs b/src/System.ComponentModel.TypeConverter/tests/AddingNewEventArgsTests.cs index 027e0735a863..2c8d529129b4 100644 --- a/src/System.ComponentModel.TypeConverter/tests/AddingNewEventArgsTests.cs +++ b/src/System.ComponentModel.TypeConverter/tests/AddingNewEventArgsTests.cs @@ -8,6 +8,12 @@ namespace System.ComponentModel.Tests { public class AddingNewEventArgsTests { + [Fact] + public void C() + { + var x = TypeDescriptor.GetConverter(typeof(Nullable)); + } + [Fact] public void Ctor_Default() { diff --git a/src/System.Diagnostics.Debug/tests/System.Diagnostics.Debug.Tests.csproj b/src/System.Diagnostics.Debug/tests/System.Diagnostics.Debug.Tests.csproj index ef77ea42d71b..ccc07a1d34bc 100644 --- a/src/System.Diagnostics.Debug/tests/System.Diagnostics.Debug.Tests.csproj +++ b/src/System.Diagnostics.Debug/tests/System.Diagnostics.Debug.Tests.csproj @@ -9,7 +9,7 @@ true - + diff --git a/src/System.IO.Pipelines/tests/System.IO.Pipelines.Tests.csproj b/src/System.IO.Pipelines/tests/System.IO.Pipelines.Tests.csproj index 133b1daff5eb..931c7fa0e468 100644 --- a/src/System.IO.Pipelines/tests/System.IO.Pipelines.Tests.csproj +++ b/src/System.IO.Pipelines/tests/System.IO.Pipelines.Tests.csproj @@ -6,7 +6,7 @@ - + diff --git a/src/System.Linq.Expressions/tests/System.Linq.Expressions.Tests.csproj b/src/System.Linq.Expressions/tests/System.Linq.Expressions.Tests.csproj index 3083cd763fab..e54845679c3d 100644 --- a/src/System.Linq.Expressions/tests/System.Linq.Expressions.Tests.csproj +++ b/src/System.Linq.Expressions/tests/System.Linq.Expressions.Tests.csproj @@ -12,7 +12,7 @@ false - + diff --git a/src/System.Net.Http.WinHttpHandler/tests/UnitTests/System.Net.Http.WinHttpHandler.Unit.Tests.csproj b/src/System.Net.Http.WinHttpHandler/tests/UnitTests/System.Net.Http.WinHttpHandler.Unit.Tests.csproj index e75c8d828a49..a70851159ea8 100644 --- a/src/System.Net.Http.WinHttpHandler/tests/UnitTests/System.Net.Http.WinHttpHandler.Unit.Tests.csproj +++ b/src/System.Net.Http.WinHttpHandler/tests/UnitTests/System.Net.Http.WinHttpHandler.Unit.Tests.csproj @@ -7,7 +7,7 @@ netstandard-Windows_NT-Debug;netstandard-Windows_NT-Release - + diff --git a/src/System.Net.Http/tests/UnitTests/System.Net.Http.Unit.Tests.csproj b/src/System.Net.Http/tests/UnitTests/System.Net.Http.Unit.Tests.csproj index 5fe36883c3b2..cb8772830d70 100644 --- a/src/System.Net.Http/tests/UnitTests/System.Net.Http.Unit.Tests.csproj +++ b/src/System.Net.Http/tests/UnitTests/System.Net.Http.Unit.Tests.csproj @@ -8,8 +8,8 @@ - - + + diff --git a/src/System.Net.Mail/tests/Unit/System.Net.Mail.Unit.Tests.csproj b/src/System.Net.Mail/tests/Unit/System.Net.Mail.Unit.Tests.csproj index 30ad853f25f7..eb0faecb2113 100644 --- a/src/System.Net.Mail/tests/Unit/System.Net.Mail.Unit.Tests.csproj +++ b/src/System.Net.Mail/tests/Unit/System.Net.Mail.Unit.Tests.csproj @@ -26,7 +26,7 @@ - + diff --git a/src/System.Net.NameResolution/tests/PalTests/System.Net.NameResolution.Pal.Tests.csproj b/src/System.Net.NameResolution/tests/PalTests/System.Net.NameResolution.Pal.Tests.csproj index ba2fc45c19aa..70c95c621c5d 100644 --- a/src/System.Net.NameResolution/tests/PalTests/System.Net.NameResolution.Pal.Tests.csproj +++ b/src/System.Net.NameResolution/tests/PalTests/System.Net.NameResolution.Pal.Tests.csproj @@ -7,7 +7,7 @@ - + diff --git a/src/System.Net.NameResolution/tests/UnitTests/System.Net.NameResolution.Unit.Tests.csproj b/src/System.Net.NameResolution/tests/UnitTests/System.Net.NameResolution.Unit.Tests.csproj index 5f3410d7ae14..ccc4d27c1930 100644 --- a/src/System.Net.NameResolution/tests/UnitTests/System.Net.NameResolution.Unit.Tests.csproj +++ b/src/System.Net.NameResolution/tests/UnitTests/System.Net.NameResolution.Unit.Tests.csproj @@ -9,7 +9,7 @@ - + diff --git a/src/System.Net.Primitives/tests/PalTests/System.Net.Primitives.Pal.Tests.csproj b/src/System.Net.Primitives/tests/PalTests/System.Net.Primitives.Pal.Tests.csproj index 061bd928a46a..c9556ab771e8 100644 --- a/src/System.Net.Primitives/tests/PalTests/System.Net.Primitives.Pal.Tests.csproj +++ b/src/System.Net.Primitives/tests/PalTests/System.Net.Primitives.Pal.Tests.csproj @@ -12,7 +12,7 @@ - + diff --git a/src/System.Net.Primitives/tests/UnitTests/System.Net.Primitives.UnitTests.Tests.csproj b/src/System.Net.Primitives/tests/UnitTests/System.Net.Primitives.UnitTests.Tests.csproj index dd3c72c53e56..5ad503eabdac 100644 --- a/src/System.Net.Primitives/tests/UnitTests/System.Net.Primitives.UnitTests.Tests.csproj +++ b/src/System.Net.Primitives/tests/UnitTests/System.Net.Primitives.UnitTests.Tests.csproj @@ -13,7 +13,7 @@ - + diff --git a/src/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj b/src/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj index 2eed4c23c82f..ff38fe72ab4b 100644 --- a/src/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj +++ b/src/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj @@ -6,7 +6,7 @@ - + diff --git a/src/System.Numerics.Tensors/tests/System.Numerics.Tensors.Tests.csproj b/src/System.Numerics.Tensors/tests/System.Numerics.Tensors.Tests.csproj index dacc43cf337f..0329734d849d 100644 --- a/src/System.Numerics.Tensors/tests/System.Numerics.Tensors.Tests.csproj +++ b/src/System.Numerics.Tensors/tests/System.Numerics.Tensors.Tests.csproj @@ -32,7 +32,7 @@ - + diff --git a/src/System.Reflection.Metadata/tests/System.Reflection.Metadata.Tests.csproj b/src/System.Reflection.Metadata/tests/System.Reflection.Metadata.Tests.csproj index 885ea7bb2cbd..aa05700a4723 100644 --- a/src/System.Reflection.Metadata/tests/System.Reflection.Metadata.Tests.csproj +++ b/src/System.Reflection.Metadata/tests/System.Reflection.Metadata.Tests.csproj @@ -139,7 +139,7 @@ - + \ No newline at end of file diff --git a/src/tests.builds b/src/tests.builds index b2b141ca8673..e41e6130f688 100644 --- a/src/tests.builds +++ b/src/tests.builds @@ -1,9 +1,5 @@ - - true - - @@ -11,10 +7,10 @@ Since IsTestProject is set to false in this case, when TargetGroup = netfx it will add net462 and net47 build configurations if they exist on the test project. We only want to build tests against current TargetGroup --> - true $(TestWorkingDir)**/coverage.xml $(ArtifactsDir)coverage + true true