New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove conditional compilation in System.Diagnostics.Tracing #19624

Closed
ViktorHofer opened this Issue May 10, 2017 · 7 comments

Comments

Projects
None yet
4 participants
@ViktorHofer
Copy link
Member

ViktorHofer commented May 10, 2017

As discussed offline with @vancem, we should remove conditional compilation which was introduced in PR #18427 when these APIs will be available in NS21:

public abstract partial class EventListener : System.IDisposable 
{ 
    protected internal virtual void OnEventWritten(System.Diagnostics.Tracing.EventWrittenEventArgs eventData) { }
}
public class EventSourceCreatedEventArgs : EventArgs 
{ 
    public EventSourceCreatedEventArgs() { } 
    public EventSource EventSource { get; } 
} 

cc @brianrob

@ViktorHofer ViktorHofer added this to the 2.1.0 milestone May 10, 2017

@ViktorHofer ViktorHofer self-assigned this May 10, 2017

@brianrob

This comment has been minimized.

Copy link
Member

brianrob commented Mar 1, 2018

@ViktorHofer, can this be fixed for 2.1? It looks to me like this would require changing desktop, is that right?

@brianrob brianrob removed this from the 2.1.0 milestone Mar 6, 2018

@brianrob

This comment has been minimized.

Copy link
Member

brianrob commented Mar 6, 2018

Moving this to future.

@brianrob brianrob added this to the Future milestone Mar 6, 2018

@ViktorHofer

This comment has been minimized.

Copy link
Member Author

ViktorHofer commented Mar 6, 2018

Sorry Brian for getting back to you so late. I see that we are currently compiling the src/test/ref projects against netcoreapp and some against uap/uapaot. I believe all these APIs should be available there and we can just safely remove the DefineConstant and the if precompiler statements. I think when I created that issue we were also building against netstandard20.

@brianrob

This comment has been minimized.

Copy link
Member

brianrob commented May 31, 2018

Marking this for the hackathon. This is about removing the preprocessor define for FEATURE_ETLEVENTS. Per @ViktorHofer it looks like this should be fairly straightforward.

@karelz karelz added the enhancement label May 31, 2018

@laurentkempe

This comment has been minimized.

Copy link
Collaborator

laurentkempe commented Jun 2, 2018

Hi, I'll try to fix this!

@karelz

This comment has been minimized.

Copy link
Member

karelz commented Jun 2, 2018

@laurentkempe great! Collaboration invite sent - see https://github.com/dotnet/corefx/wiki/Hackathon#how-can-i-grab-an-issue for details.

@karelz karelz self-assigned this Jun 2, 2018

@laurentkempe

This comment has been minimized.

Copy link
Collaborator

laurentkempe commented Jun 2, 2018

@karelz ok I accepted the invitation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment