Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MessagePack Reference Loop Handling #42815

Closed
AllanMichaelsen opened this issue Jan 12, 2020 · 4 comments
Closed

MessagePack Reference Loop Handling #42815

AllanMichaelsen opened this issue Jan 12, 2020 · 4 comments

Comments

@AllanMichaelsen
Copy link

@AllanMichaelsen AllanMichaelsen commented Jan 12, 2020

I know there is a thread for handling this with Json ( #38579 ), but the issue also exists with message pack protocol.(MPP)

When switching to binary serialization via MPP there are immediate buffer overflow issues.

Is there a way to handle this with MPP?

@davidfowl

This comment has been minimized.

Copy link
Contributor

@davidfowl davidfowl commented Jan 12, 2020

There's no message pack implementation built into .NET, you might want to file an issue here https://github.com/neuecc/MessagePack-CSharp/issues

@AllanMichaelsen

This comment has been minimized.

Copy link
Author

@AllanMichaelsen AllanMichaelsen commented Jan 12, 2020

I know that the .AddMessagePackProtocol uses neuecc, but is it there the issue occurs or is it in the .AddMessagePackProtocol itself?

@davidfowl

This comment has been minimized.

Copy link
Contributor

@davidfowl davidfowl commented Jan 12, 2020

Yes its a serializer issue.

@GrabYourPitchforks

This comment has been minimized.

Copy link
Member

@GrabYourPitchforks GrabYourPitchforks commented Jan 14, 2020

Closing as external. Please use the issue tracker David referenced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.