This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add more String.Concat tests #8052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM |
|
LGTM. Sorry for creating the merge conflict ;) |
Member
Author
No problem. I merged your change knowing it would conflict 😄 |
Tests covering a few more special cases of String.Concat, including checking for a string.Empty optimization and a mini-stress test that tries to trigger the fallback defensive-copy case in String.Concat.
stephentoub
force-pushed
the
string_tests
branch
from
c7eaca0 to
d01770c
Compare
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Add more String.Concat tests Commit migrated from dotnet/corefx@df00879
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests covering a few more special cases of String.Concat, including checking for a string.Empty optimization and a mini-stress test that tries to trigger the fallback defensive-copy case in String.Concat.
cc: @jkotas, @ellismg
(This won't pass CI until dotnet/coreclr#4559 is merged, due to the new checks for Assert.Same for the empty string case. That optimization existed for the other string.Concat overloads, but not for the string[] one previously.)