Adding initial implementation of the FileSystemWatcher on OS X#1193
Adding initial implementation of the FileSystemWatcher on OS X#1193jonmill merged 3 commits intodotnet:masterfrom jonmill:filesystemwatcher
Conversation
There was a problem hiding this comment.
We should add an Interop.Libraries.cs file under src/Common/src/Interop/OSX, and put this constant in there.
|
Thanks, Jon. Good start. Took a first pass through and left a bunch of comments. I can review it again when you've taken a pass through to address them. |
|
@sokket, When you get a chance can you update your git user.email to be the microsoft.com address you have registered with your github account and then update your commit with git commit --amend --reset-author? Right now it is showing up as an outlook.com address. |
There was a problem hiding this comment.
Shouldn't this be if (!String.IsNullOrEmpty(_directory)) instead of checking for == false?
There was a problem hiding this comment.
They both provide the same functionality but I prefer the == false since it's so easy to miss the preceding ! and misread the conditional. If there's strong preference or precedence to using ! over == false then I'll go ahead and change it
9 participants
No description provided.