Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Expose GC.GetAllocatedBytesForCurrentThread in netcoreapp1.1#12489

Merged
stephentoub merged 1 commit into
dotnet:masterfrom
jkotas:GetAllocatedBytesForCurrentThread
Oct 9, 2016
Merged

Expose GC.GetAllocatedBytesForCurrentThread in netcoreapp1.1#12489
stephentoub merged 1 commit into
dotnet:masterfrom
jkotas:GetAllocatedBytesForCurrentThread

Conversation

@jkotas

@jkotas jkotas commented Oct 9, 2016

Copy link
Copy Markdown
Member

No description provided.

@jkotas

jkotas commented Oct 9, 2016

Copy link
Copy Markdown
Member Author

Fix #10157

cc @Maoni0

@stephentoub

stephentoub commented Oct 9, 2016

Copy link
Copy Markdown
Member

@dotnet-bot Test Innerloop Ubuntu14.04 Debug Build and Test please (build timeout) FYI, @mmitche and @adityamandaleeka

@stephentoub

stephentoub commented Oct 9, 2016

Copy link
Copy Markdown
Member

LGTM

@stephentoub
stephentoub merged commit a8f2bf2 into dotnet:master Oct 9, 2016
@jkotas
jkotas deleted the GetAllocatedBytesForCurrentThread branch October 9, 2016 15:00
@mmitche

mmitche commented Oct 9, 2016

Copy link
Copy Markdown
Member

@stephentoub Are you sure we should be merging these? They're timeouts while running tests.

/mnt/j/workspace/dotnet_corefx/master/ubuntu14.04_debug_prtest/Tools/tests.targets(271,5): error : One or more tests failed while running tests from 'System.Reflection.Emit.Tests' please check log for details! [/mnt/j/workspace/dotnet_corefx/master/ubuntu14.04_debug_prtest/src/System.Reflection.Emit/tests/System.Reflection.Emit.Tests.csproj]

@stephentoub

stephentoub commented Oct 9, 2016

Copy link
Copy Markdown
Member

@mmitche, that's how the issue I've been mentioning on Ubuntu manifests, and why I've started to cc you and Aditya. It's not specific to any particular test suite; it just ends up spinning page failing at seemingly random places. This PR didn't change and doesn't impact that test suite.

@Maoni0

Maoni0 commented Oct 10, 2016

Copy link
Copy Markdown
Member

cool :) thanks Jan. @swgillespie, @KrzysztofCwalina, - you don't need to use reflection on this anymore.

@adamsitnik adamsitnik mentioned this pull request Oct 11, 2016
Merged
@justinvp justinvp mentioned this pull request Oct 13, 2016
Merged
@adamsitnik adamsitnik mentioned this pull request Oct 16, 2016
Merged
@karelz karelz modified the milestone: 1.2.0 Dec 3, 2016
@Lexcess Lexcess mentioned this pull request Jun 10, 2018
Closed
@adamsitnik adamsitnik mentioned this pull request Jan 31, 2020
Closed
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@stephentoub
Merge pull request dotnet/corefx#12489 from jkotas/GetAllocatedBytesF…
1816809 
…orCurrentThread

Expose GC.GetAllocatedBytesForCurrentThread in netcoreapp1.1

Commit migrated from dotnet/corefx@a8f2bf2
@MartyIX MartyIX mentioned this pull request May 20, 2024
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@jkotas @stephentoub @mmitche @Maoni0 @karelz @dnfclas