New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose GC.GetAllocatedBytesForCurrentThread in netcoreapp1.1 #12489

Merged
merged 1 commit into from Oct 9, 2016

Conversation

Projects
None yet
6 participants
@jkotas
Member

jkotas commented Oct 9, 2016

No description provided.

@jkotas

This comment has been minimized.

Show comment
Hide comment
@jkotas
Member

jkotas commented Oct 9, 2016

Fix #10157

cc @Maoni0

@stephentoub

This comment has been minimized.

Show comment
Hide comment
@stephentoub

stephentoub Oct 9, 2016

Member

@dotnet-bot Test Innerloop Ubuntu14.04 Debug Build and Test please (build timeout) FYI, @mmitche and @adityamandaleeka

Member

stephentoub commented Oct 9, 2016

@dotnet-bot Test Innerloop Ubuntu14.04 Debug Build and Test please (build timeout) FYI, @mmitche and @adityamandaleeka

@stephentoub

This comment has been minimized.

Show comment
Hide comment
@stephentoub

stephentoub Oct 9, 2016

Member

LGTM

Member

stephentoub commented Oct 9, 2016

LGTM

@stephentoub stephentoub merged commit a8f2bf2 into dotnet:master Oct 9, 2016

10 checks passed

Innerloop CentOS7.1 Debug Build and Test Build finished.
Details
Innerloop CentOS7.1 Release Build and Test Build finished.
Details
Innerloop Linux ARM Emulator Debug Cross Build Build finished.
Details
Innerloop Linux ARM Emulator Release Cross Build Build finished.
Details
Innerloop OSX Debug Build and Test Build finished.
Details
Innerloop OSX Release Build and Test Build finished.
Details
Innerloop Ubuntu14.04 Debug Build and Test Build finished.
Details
Innerloop Ubuntu14.04 Release Build and Test Build finished.
Details
Innerloop Windows_NT Debug Build and Test Build finished.
Details
Innerloop Windows_NT Release Build and Test Build finished.
Details

@jkotas jkotas deleted the jkotas:GetAllocatedBytesForCurrentThread branch Oct 9, 2016

@mmitche

This comment has been minimized.

Show comment
Hide comment
@mmitche

mmitche Oct 9, 2016

Member

@stephentoub Are you sure we should be merging these? They're timeouts while running tests.

/mnt/j/workspace/dotnet_corefx/master/ubuntu14.04_debug_prtest/Tools/tests.targets(271,5): error : One or more tests failed while running tests from 'System.Reflection.Emit.Tests' please check log for details! [/mnt/j/workspace/dotnet_corefx/master/ubuntu14.04_debug_prtest/src/System.Reflection.Emit/tests/System.Reflection.Emit.Tests.csproj]

Member

mmitche commented Oct 9, 2016

@stephentoub Are you sure we should be merging these? They're timeouts while running tests.

/mnt/j/workspace/dotnet_corefx/master/ubuntu14.04_debug_prtest/Tools/tests.targets(271,5): error : One or more tests failed while running tests from 'System.Reflection.Emit.Tests' please check log for details! [/mnt/j/workspace/dotnet_corefx/master/ubuntu14.04_debug_prtest/src/System.Reflection.Emit/tests/System.Reflection.Emit.Tests.csproj]

@stephentoub

This comment has been minimized.

Show comment
Hide comment
@stephentoub

stephentoub Oct 9, 2016

Member

@mmitche, that's how the issue I've been mentioning on Ubuntu manifests, and why I've started to cc you and Aditya. It's not specific to any particular test suite; it just ends up spinning page failing at seemingly random places. This PR didn't change and doesn't impact that test suite.

Member

stephentoub commented Oct 9, 2016

@mmitche, that's how the issue I've been mentioning on Ubuntu manifests, and why I've started to cc you and Aditya. It's not specific to any particular test suite; it just ends up spinning page failing at seemingly random places. This PR didn't change and doesn't impact that test suite.

@Maoni0

This comment has been minimized.

Show comment
Hide comment
@Maoni0

Maoni0 Oct 10, 2016

Member

cool :) thanks Jan. @swgillespie, @KrzysztofCwalina, - you don't need to use reflection on this anymore.

Member

Maoni0 commented Oct 10, 2016

cool :) thanks Jan. @swgillespie, @KrzysztofCwalina, - you don't need to use reflection on this anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment