Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Arm/CI] Add hardfp build to arm32_ci_script.sh #12577

Merged
merged 1 commit into from Oct 13, 2016

Conversation

Projects
None yet
4 participants
@wateret
Copy link
Member

commented Oct 12, 2016

Now hardfp is default. For softfp, --softfp must be given as an argument.

Related Issue : #12545

[Arm/CI] Add hardfp build to arm32_ci_script.sh
Now hardfp is default. For softfp, `--softfp` must be given as an argument.

Related Issue : #12545
@wateret

This comment has been minimized.

Copy link
Member Author

commented Oct 12, 2016

Changes in arm32_ci_script.sh only. There is no effect to CI's behavior. Will keep working on it after adding rootfs image for arm-hardfp to CI.

@wateret

This comment has been minimized.

Copy link
Member Author

commented Oct 12, 2016

It is natural that Innerloop Linux ARM Emulator checks fail because there is a little change on usage of arm32_ci_script.sh

@stephentoub

This comment has been minimized.

Copy link
Member

commented Oct 12, 2016

It is natural that Innerloop Linux ARM Emulator checks fail because there is a little change on usage of arm32_ci_script.sh

How will that be fixed? We don't want to merge this if it's going to cause all PRs to start failing.

@wateret

This comment has been minimized.

Copy link
Member Author

commented Oct 13, 2016

@stephentoub I changed the usage of arm32_ci_script.sh and there was changes in netci.groovy accordingly. AFAIK I can't test changes for netci.groovy before it is merged and that's why the CI complains. I think there would be no problem once it is merged.

@stephentoub

This comment has been minimized.

Copy link
Member

commented Oct 13, 2016

@dotnet-bot test ci please

@stephentoub

This comment has been minimized.

Copy link
Member

commented Oct 13, 2016

I changed the usage of arm32_ci_script.sh and there was changes in netci.groovy accordingly. AFAIK I can't test changes for netci.groovy before it is merged and that's why the CI complains. I think there would be no problem once it is merged.

Ok, thanks. We can go ahead with it, and then we'll need to disable the emulator legs if that turns out not to be the case.

@stephentoub stephentoub merged commit 9a349d2 into dotnet:master Oct 13, 2016

9 of 11 checks passed

Innerloop Linux ARM Emulator Debug Cross Build Build finished.
Details
Innerloop Linux ARM Emulator Release Cross Build Build finished.
Details
Innerloop CentOS7.1 Debug Build and Test Build finished.
Details
Innerloop CentOS7.1 Release Build and Test Build finished.
Details
Innerloop OSX Debug Build and Test Build finished.
Details
Innerloop OSX Release Build and Test Build finished.
Details
Innerloop Ubuntu14.04 Debug Build and Test Build finished.
Details
Innerloop Ubuntu14.04 Release Build and Test Build finished.
Details
Innerloop Windows_NT Debug Build and Test Build finished.
Details
Innerloop Windows_NT Release Build and Test Build finished.
Details
dotnet_corefx/master/GenPRTest/generator_prtest Build finished.
Details
@wateret

This comment has been minimized.

Copy link
Member Author

commented Oct 13, 2016

@dotnet-bot test ci please

@karelz karelz modified the milestone: 1.2.0 Dec 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.