Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
implement synchronous completion support in Sockets #15141
referenced this pull request
Jan 12, 2017
Nice job, @geoffkizer. Do you have any perf measurements you can share on the impact of this on some microbenchmarks? I'd expect it to be fairly significant. Once it's merged in I'll plan to rerun some of my experiments with the managed ClientWebSocket implementation; I'd seen some notable perf hits because of this, so hopefully it'll see some sizeable improvements.
Quick and dirty perf results on my machine:
For my simple request/response test, req/s went from 61016 to 70101, or about 15% improvement.
This is Windows, my crappy laptop, client GC, using SocketAsyncEventArgs.
The improvement I previously saw on bigger hardware was larger, but I don't have access to that hardware at the moment.