This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Cleanup a few more empty array allocations and Contract.Asserts #1579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing two occurences of: ``` private static readonly T[] s_emptyArray = new T[0]; ``` fields, and replacing call sites with usage of ```Array.Empty<T>()```.
A few more Contract.Assert calls have snuck in. Continuing on our policy of standardizing on Debug.Assert for asserts, replacing all of them. The only Contract.Assert calls that currently remain in the repo after this are those used in System.Diagnostics.Contracts tests.
stephentoub
force-pushed
the
more_search_replace
branch
from
3bce67b to
f70d30a
Compare
|
LGTM |
ellismg
added a commit
that referenced
this pull request
Apr 30, 2015
Cleanup a few more empty array allocations and Contract.Asserts
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…place Cleanup a few more empty array allocations and Contract.Asserts Commit migrated from dotnet/corefx@cd67f03
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two search-and-replace changes:
private static readonly T[] s_emptyArray = new T[0];occurrences with usage ofArray.Empty<T>().Contract.Asserts that snuck in withDebug.Asserts, continuing with our policy of standardizing onDebug.Assertfor asserts.