Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add support for System.Drawing on Windows. #20593
This change adds a new library, System.Drawing.Common, which supports a large subset of the System.Drawing API. It is a direct port of the code from the .NET Framework codebase. The code has been cleaned, formatted, and sanitized to match the code style of corefx, but is otherwise very
There is still further cleanup that can be done in order to match the style and structure of corefx. For example, the interop code should be reorganized to match other BCL libraries.
NOTE: This implementation will only work on Windows, and not in UWP. This is a strictly compatibility-driven feature. Any changes made to it should not significantly diverge from the .NET Framework implementation. Libraries should only take a dependency on System.Drawing.Common if they
@stephentoub I think there's a few things I'd like to accomplish before being "ready to merge":
referenced this pull request
Jun 2, 2017
Sounds great; I could definitely use some help with that. I ported a select few test cases and tried running them against the implementation here, but there's still a ton of work to be done there. Porting from Nunit to Xunit was fairly annoying and time-consuming, and after that there were still minor differences that caused lots of tests to fail. I will file another issue tomorrow about this so we can try to plan it out and split up the work.