New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release the StringBuilder back to the StringBuilderCache. #2277

Merged
merged 1 commit into from Jul 8, 2015

Conversation

Projects
None yet
4 participants
@AustinWise
Collaborator

AustinWise commented Jul 8, 2015

Fixes #2275

@dnfclas

This comment has been minimized.

Show comment
Hide comment
@dnfclas

dnfclas Jul 8, 2015

@AustinWise, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

dnfclas commented Jul 8, 2015

@AustinWise, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

@dnfclas dnfclas added the cla-signed label Jul 8, 2015

@stephentoub

View changes

Show outdated Hide outdated src/System.Runtime.Extensions/src/System/IO/Path.Unix.cs
@stephentoub

This comment has been minimized.

Show comment
Hide comment
@stephentoub

stephentoub Jul 8, 2015

Member

Thanks for the fix and the revision. LGTM.

Member

stephentoub commented Jul 8, 2015

Thanks for the fix and the revision. LGTM.

@stephentoub

This comment has been minimized.

Show comment
Hide comment
@stephentoub

stephentoub Jul 8, 2015

Member

@AustinWise, could you squash these? I didn't notice previously that this was done as two commits, and the second really obviates the first rather than builds on it.

Member

stephentoub commented Jul 8, 2015

@AustinWise, could you squash these? I didn't notice previously that this was done as two commits, and the second really obviates the first rather than builds on it.

@AustinWise

This comment has been minimized.

Show comment
Hide comment
@AustinWise

AustinWise Jul 8, 2015

Collaborator

Yeah, I'll do that. I was just not sure if it would mess up the pull request somehow if I edited the commits.

Collaborator

AustinWise commented Jul 8, 2015

Yeah, I'll do that. I was just not sure if it would mess up the pull request somehow if I edited the commits.

@stephentoub

This comment has been minimized.

Show comment
Hide comment
@stephentoub

stephentoub Jul 8, 2015

Member

Cool, thanks 😄

Member

stephentoub commented Jul 8, 2015

Cool, thanks 😄

stephentoub added a commit that referenced this pull request Jul 8, 2015

Merge pull request #2277 from AustinWise/issue-#2275
Release the StringBuilder back to the StringBuilderCache.

@stephentoub stephentoub merged commit 0fa3956 into dotnet:master Jul 8, 2015

1 check passed

default Build finished. No test results found.
Details

@karelz karelz modified the milestone: 1.0.0-rtm Dec 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment